sndpp: take a path object in ctor methods

Author: craftablescience

include/sndpp/RIFF.h

@@ -1,7 +1,7 @@
 #pragma once
 
+#include <filesystem>
 #include <span>
-#include <string>
 #include <utility>
 #include <vector>
 
@@ -21,7 +21,7 @@ class RIFF {
 
 	explicit RIFF(std::span<const std::byte> riffData, uint32_t type_);
 
-	explicit RIFF(const std::string& riffPath, uint32_t type_);
+	explicit RIFF(const std::filesystem::path& riffPath, uint32_t type_);
 
 	[[nodiscard]] explicit operator bool() const;
 

include/sndpp/WAV.h

@@ -173,7 +173,7 @@ class WAV : public RIFF {
 
 	explicit WAV(std::span<const std::byte> wavData);
 
-	explicit WAV(const std::string& wavPath);
+	explicit WAV(const std::filesystem::path& wavPath);
 
 	template<ChunkType Type>
 	[[nodiscard]] auto getFirstWAVChunk() const {

include/sndpp/XWV.h

@@ -1,7 +1,7 @@
 #pragma once
 
+#include <filesystem>
 #include <span>
-#include <string>
 #include <vector>
 
 #include <sourcepp/parser/Binary.h>
@@ -31,7 +31,7 @@ class XWV {
 
 	explicit XWV(std::span<const std::byte> xwvData);
 
-	explicit XWV(const std::string& xwvPath);
+	explicit XWV(const std::filesystem::path& xwvPath);
 
 	explicit operator bool() const;
 

src/sndpp/RIFF.cpp

@@ -3,7 +3,6 @@
 #include <algorithm>
 
 #include <BufferStream.h>
-#include <filesystem>
 #include <sourcepp/FS.h>
 
 using namespace sndpp;
@@ -48,7 +47,7 @@ RIFF::RIFF(std::vector<std::byte>&& riffData, uint32_t type_)
 RIFF::RIFF(std::span<const std::byte> riffData, uint32_t type_)
 		: RIFF{std::vector<std::byte>{riffData.begin(), riffData.end()}, type_} {}
 
-RIFF::RIFF(const std::string& riffPath, uint32_t type_)
+RIFF::RIFF(const std::filesystem::path& riffPath, uint32_t type_)
 		: RIFF{fs::readFileBuffer(riffPath), type_} {}
 
 RIFF::operator bool() const {

src/sndpp/WAV.cpp

@@ -16,5 +16,5 @@ WAV::WAV(std::vector<std::byte>&& wavData)
 WAV::WAV(std::span<const std::byte> wavData)
 		: RIFF{wavData, WAV_TYPE} {}
 
-WAV::WAV(const std::string& wavPath)
+WAV::WAV(const std::filesystem::path& wavPath)
 		: RIFF{wavPath, WAV_TYPE} {}

src/sndpp/XWV.cpp

@@ -134,7 +134,7 @@ XWV::XWV(std::span<const std::byte> xwvData)
 	this->opened = true;
 }
 
-XWV::XWV(const std::string& xwvPath)
+XWV::XWV(const std::filesystem::path& xwvPath)
 		: XWV(fs::readFileBuffer(xwvPath)) {}
 
 XWV::operator bool() const {