Skip to content

Commit f723828

Browse files
committed
Fix flaky test
1 parent 09d8bf8 commit f723828

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

tests/Http/Controllers/Settings/UserSettingsControllerTest.php

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,13 +46,13 @@
4646
test('require2fa only gets saved when above team edition', function () {
4747
Edition::set(Edition::Solo);
4848

49-
expect(ProjectConfig::get('users.require2fa'))->toBe(false);
49+
expect(ProjectConfig::get('users.require2fa'))->toBeFalsy();
5050

5151
post(action([UserSettingsController::class, 'store'], [
5252
'require2fa' => true,
5353
]))->assertRedirectBack();
5454

55-
expect(ProjectConfig::get('users.require2fa'))->toBe(false);
55+
expect(ProjectConfig::get('users.require2fa'))->toBeFalsy();
5656

5757
Edition::set(Edition::Team);
5858

@@ -66,13 +66,21 @@
6666
test('user settings only get saved when above pro edition', function (string $property, mixed $default, mixed $value) {
6767
Edition::set(Edition::Team);
6868

69-
expect(ProjectConfig::get("users.$property"))->toBeIn([$default, (bool) $default]);
69+
if ($default) {
70+
expect(ProjectConfig::get("users.$property"))->toBeTruthy();
71+
} else {
72+
expect(ProjectConfig::get("users.$property"))->toBeFalsy();
73+
}
7074

7175
post(action([UserSettingsController::class, 'store'], [
7276
$property => $value,
7377
]))->assertRedirectBack();
7478

75-
expect(ProjectConfig::get("users.$property"))->toBeIn([$default, (bool) $default]);
79+
if ($default) {
80+
expect(ProjectConfig::get("users.$property"))->toBeTruthy();
81+
} else {
82+
expect(ProjectConfig::get("users.$property"))->toBeFalsy();
83+
}
7684

7785
Edition::set(Edition::Pro);
7886

0 commit comments

Comments
 (0)