Differences between logic to update descendant slugs

[jlawrence-yellostudio]

Hi @brandonkelly

I thought i'd make this as a discussion rather than an issue as i'm not sure what the exact problem is, i'm currently experiencing a discrepancy where the child URIs are not always updating to match the parent slug, the issue is that it is intermittent.

Looking at the 3 latest versions of elements\Entry.php i can see that each version has different logic:

3.9.15

    if (!$this->duplicateOf && $section->type == Section::TYPE_STRUCTURE) {
        // Has the parent changed?
        if ($this->hasNewParent()) {
            $this->_placeInStructure($isNew, $section);
        }

        // Update the entry’s descendants, who may be using this entry’s URI in their own URIs
        if (!$isNew && $this->getIsCanonical()) {
            Craft::$app->getElements()->updateDescendantSlugsAndUris($this, true, true);
        }
    }

4.16.12

    if ($this->getIsCanonical() && $section->type == Section::TYPE_STRUCTURE) {
        // Has the parent changed?
        if ($this->_hasNewParent()) {
            $this->_placeInStructure($isNew, $section);
        }

        // Update the entry's descendants, who may be using this entry's URI in their own URIs
        if (!$isNew) {
            Craft::$app->getElements()->updateDescendantSlugsAndUris($this, true, true);
        }
    }

5.8.16

    if (
        (!$this->duplicateOf || $this->placeInStructure) &&
        isset($this->sectionId) &&
        $section->type == Section::TYPE_STRUCTURE
    ) {
        // Has the parent changed?
        if ($this->placeInStructure || $this->hasNewParent()) {
            $this->_placeInStructure($isNew, $section);
        }

        // Update the entry’s descendants, who may be using this entry’s URI in their own URIs
        if (!$isNew && $this->getIsCanonical()) {
            Craft::$app->getElements()->updateDescendantSlugsAndUris($this, true, true);
        }
    }

I can understand 5.x being different but not the 4.x and 3.x versions, particularly considering this fix in 3.x:

#10094

Basically the behaviour i'm seeing is that when using a queue, that it will work for say 5 times in a row, and then suddenly not, resulting in the children having the incorrect URIs.

I'm on 4.16.12 which is the same as 4.16.19 for this file and i've reviewed the change log to see there is anything related to this issue.

Any thoughts you might have would be useful, right now we've told the customer to manually resave the children, although this is quite laborious as you might guess.

[brandonkelly]

Thanks for pointing that out! It’s fixed now for the next Craft 4 and 5 releases.

[brandonkelly]

4.16.13 and 5.8.17 are out with that fix. Thanks again!