[Need a review] HestiCP & Craft CMS

[anvme]

Hello!

Guys, I need a review from you.
If you know HestiaCP NGINX templates. Check the pull request, please.

hestiacp/hestiacp#1973

[angrybrad]

I'm not familiar with HestiaCP, so can't comments on the project-specific syntax, but there are a few nginx location blocks that seem unnecessary.

Specifically these:

    location ^~ /index.php/admin {
        try_files $uri $uri/ @phpfpm_nocache;
    }

...

    location ^~ /actions {
        try_files $uri $uri/ /index.php?$query_string;
    }

The rest looks fine to me, though.

[anvme]

I'm not familiar with HestiaCP, so can't comments on the project-specific syntax, but there are a few nginx location blocks that seem unnecessary.

Specifically these:

    location ^~ /index.php/admin {
        try_files $uri $uri/ @phpfpm_nocache;
    }

...

    location ^~ /actions {
        try_files $uri $uri/ /index.php?$query_string;
    }

The rest looks fine to me, though.

oh, taken from here https://github.com/nystudio107/nginx-craft/blob/master/forge-templates/NginxFastCGICacheTemplate.conf#L126

[khalwat]

Those are needed if you're using a FastCGI Cache. If you're not, they are not needed.