Fixed #4265

Author: lukeholder

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Release Notes for Craft Commerce
 
+## Unreleased
+
+- Fixed a bug where PDF Link Duration didn't save. ([#4265](https://github.com/craftcms/commerce/issues/4265))
+
 ## 4.11.0 - 2026-03-11
 
 - Craft Commerce now requires Craft CMS 4.17.9 or later.

src/Plugin.php

@@ -212,7 +212,7 @@ public static function editions(): array
     /**
      * @inheritDoc
      */
-    public string $schemaVersion = '4.9.0.1';
+    public string $schemaVersion = '4.11.0.2';
 
     /**
      * @inheritdoc

src/controllers/PdfsController.php

@@ -111,6 +111,7 @@ public function actionSave(): ?Response
         $pdf->enabled = $this->request->getBodyParam('enabled');
         $pdf->isDefault = $this->request->getBodyParam('isDefault');
         $pdf->language = $this->request->getBodyParam('language');
+        $pdf->linkExpiry = (int)$this->request->getBodyParam('linkExpiry');
 
         // Save it
         if ($pdfsService->savePdf($pdf)) {

src/migrations/Install.php

@@ -227,6 +227,7 @@ public function createTables(): void
             'isDefault' => $this->boolean()->notNull()->defaultValue(false),
             'sortOrder' => $this->integer(),
             'language' => $this->string(),
+            'linkExpiry' => $this->integer()->notNull()->defaultValue(86400),
             'dateCreated' => $this->dateTime()->notNull(),
             'dateUpdated' => $this->dateTime()->notNull(),
             'uid' => $this->uid(),

src/migrations/m260327_000000_ensure_link_expiry_on_pdfs.php

@@ -0,0 +1,33 @@
+<?php
+
+namespace craft\commerce\migrations;
+
+use craft\commerce\db\Table;
+use craft\db\Migration;
+
+/**
+ * m260327_000000_ensure_link_expiry_on_pdfs migration.
+ */
+class m260327_000000_ensure_link_expiry_on_pdfs extends Migration
+{
+    /**
+     * @inheritdoc
+     */
+    public function safeUp(): bool
+    {
+        if (!$this->db->columnExists(Table::PDFS, 'linkExpiry')) {
+            $this->addColumn(Table::PDFS, 'linkExpiry', $this->integer()->notNull()->defaultValue(86400)->after('language'));
+        }
+
+        return true;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function safeDown(): bool
+    {
+        echo "m260327_000000_ensure_link_expiry_on_pdfs cannot be reverted.\n";
+        return false;
+    }
+}

src/services/Pdfs.php

@@ -335,6 +335,7 @@ public function handleChangedPdf(ConfigEvent $event): void
             $pdfRecord->sortOrder = $data['sortOrder'];
             $pdfRecord->isDefault = $data['isDefault'];
             $pdfRecord->language = $data['language'] ?? PdfRecord::LOCALE_ORDER_LANGUAGE;
+            $pdfRecord->linkExpiry = $data['linkExpiry'] ?? 86400;
 
             $pdfRecord->uid = $pdfUid;
 
@@ -641,7 +642,7 @@ private function _getPdfRecord(string $uid): PdfRecord
      */
     private function _createPdfsQuery(): Query
     {
-        return (new Query())
+        $query = (new Query())
             ->select([
                 'description',
                 'enabled',
@@ -658,5 +659,12 @@ private function _createPdfsQuery(): Query
             ->orderBy('name')
             ->from([Table::PDFS])
             ->orderBy(['sortOrder' => SORT_ASC]);
+
+        // TODO: remove after next breakpoint
+        if (Craft::$app->getDb()->columnExists(Table::PDFS, 'linkExpiry')) {
+            $query->addSelect('linkExpiry');
+        }
+
+        return $query;
     }
 }