Fix negative refund amount

lukeholder · lukeholder · commit e0a10ea8becc · 2025-12-30T22:27:14.000+08:00
diff --git a/src/controllers/OrdersController.php b/src/controllers/OrdersController.php
@@ -1238,11 +1238,11 @@ public function actionTransactionRefund(): Response
             }
         }
 
-        if (!$amount) {
+        if (!$amount || $amount <= 0) {
             $amount = $transaction->getRefundableAmount();
         }
 
-        if ($amount > $transaction->getRefundableAmount()) {
+        if ($amount <= 0 || $amount > $transaction->getRefundableAmount()) {
             $error = Craft::t('commerce', 'Can not refund amount greater than the remaining amount');
             if ($this->request->getAcceptsJson()) {
                 return $this->asFailure($error);

Original file line number	Diff line number	Diff line change
`@@ -1238,11 +1238,11 @@ public function actionTransactionRefund(): Response`
`1238`	`1238`	`}`
`1239`	`1239`	`}`
`1240`	`1240`
`1241`		`- if (!$amount) {`
	`1241`	`+ if (!$amount \|\| $amount <= 0) {`
`1242`	`1242`	`$amount = $transaction->getRefundableAmount();`
`1243`	`1243`	`}`
`1244`	`1244`
`1245`		`- if ($amount > $transaction->getRefundableAmount()) {`
	`1245`	`+ if ($amount <= 0 \|\| $amount > $transaction->getRefundableAmount()) {`
`1246`	`1246`	`$error = Craft::t('commerce', 'Can not refund amount greater than the remaining amount');`
`1247`	`1247`	`if ($this->request->getAcceptsJson()) {`
`1248`	`1248`	`return $this->asFailure($error);`