#189 throw errors if no item data is retrieved from the data file

Author: nfourtythree

CHANGELOG.md

@@ -1,5 +1,10 @@
 # Release Notes for Shopify
 
+## Unreleased
+
+- Fixed a bug where syncing queue jobs could run indefinitely. ([#189](https://github.com/craftcms/shopify/issues/189))
+- Fixed a bug where syncing products could fail if the sync file had downloaded incorrectly.
+
 ## 6.1.1 - 2025-11-06
 
 - Fixed a bug where file storage could be maxed out when using multiple queue workers.

src/api/BulkDataBatcher.php

@@ -32,6 +32,14 @@ class BulkDataBatcher implements Batchable
      */
     public function getSlice(int $offset, int $limit): iterable
     {
+        if (!file_exists($this->filePath)) {
+            throw new \Exception('File not found: ' . $this->filePath);
+        }
+
+        if (filesize($this->filePath) === 0) {
+            throw new \Exception('File is empty: ' . $this->filePath);
+        }
+
         // Seek forward in the file by the number of lines in the offset
         $fileObject = new \SplFileObject($this->filePath);
         $fileObject->seek($offset === 0 ? 0 : $offset - 1);
@@ -44,6 +52,10 @@ public function getSlice(int $offset, int $limit): iterable
             $i++;
         }
 
+        if (empty($lines)) {
+            throw new \Exception('No more lines to read from the file.');
+        }
+
         return collect($lines);
     }