Fixed #176 PHP error on saving product drafts

Author: nfourtythree

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## Unreleased
 
 - Fixed a PHP error that occurred when setting the Shopify host name to a non `myshopify` domain. ([#168](https://github.com/craftcms/shopify/issues/168))
+- Fixed a PHP error that occurred when creating product drafts. ([#176](https://github.com/craftcms/shopify/issues/176))
 
 ## 6.0.3 - 2025-05-27
 

src/Plugin.php

@@ -67,7 +67,7 @@ class Plugin extends BasePlugin
     /**
      * @var string
      */
-    public string $schemaVersion = '6.0.3.1';
+    public string $schemaVersion = '6.0.4.0';
 
     /**
      * @inheritdoc

src/elements/Product.php

@@ -752,7 +752,7 @@ public function afterSave(bool $isNew): void
     public function afterDelete(): void
     {
         // Remove all the product shopify data
-        if ($this->shopifyGid) {
+        if ($this->shopifyGid && $this->getIsCanonical()) {
             Plugin::getInstance()->getProducts()->deleteShopifyDataByShopifyId($this->shopifyGid);
         }
 

src/migrations/m250808_100206_update_shopify_product_indexes.php

@@ -0,0 +1,36 @@
+<?php
+
+namespace craft\shopify\migrations;
+
+use Craft;
+use craft\db\Migration;
+use craft\shopify\db\Table;
+
+/**
+ * m250808_100206_update_shopify_product_indexes migration.
+ */
+class m250808_100206_update_shopify_product_indexes extends Migration
+{
+    /**
+     * @inheritdoc
+     */
+    public function safeUp(): bool
+    {
+        $this->dropIndexIfExists(Table::PRODUCTS, ['shopifyId'], true);
+        $this->dropIndexIfExists(Table::PRODUCTS, ['shopifyGid'], true);
+
+        $this->createIndexIfMissing(Table::PRODUCTS, ['shopifyId']);
+        $this->createIndexIfMissing(Table::PRODUCTS, ['shopifyGid']);
+
+        return true;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function safeDown(): bool
+    {
+        echo "m250808_100206_update_shopify_product_indexes cannot be reverted.\n";
+        return false;
+    }
+}