Skip to content

Commit 8f851e7

Browse files
committed
Use Queue::push()
1 parent 267b151 commit 8f851e7

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212

1313
### Fixed
1414
- Fixed an error that could occur when calling `craft\webhooks\Plugin::getRequestData()` if an invalid request ID was passed.
15+
- Fixed an exception that could occur when retrying webhook requests, if the queue driver didn’t support delayed jobs.
1516

1617
## 2.3.3 - 2021-04-01
1718

src/Plugin.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
use craft\helpers\ArrayHelper;
1010
use craft\helpers\Db;
1111
use craft\helpers\Json;
12+
use craft\helpers\Queue;
1213
use craft\helpers\StringHelper;
1314
use craft\web\UrlManager;
1415
use craft\webhooks\filters\DraftFilter;
@@ -318,9 +319,8 @@ public function request(string $method, string $url, array $headers = null, stri
318319
*/
319320
public function pushPendingJobs()
320321
{
321-
$queue = Craft::$app->getQueue();
322322
while ($job = array_shift($this->_pendingJobs)) {
323-
$queue->push($job);
323+
Queue::push($job);
324324
}
325325
}
326326

src/SendRequestJob.php

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
use craft\db\Query;
77
use craft\helpers\Db;
88
use craft\helpers\Json;
9+
use craft\helpers\Queue;
910
use craft\queue\BaseJob;
1011
use GuzzleHttp\Exception\RequestException;
1112
use GuzzleHttp\RequestOptions;
@@ -61,11 +62,9 @@ public function execute($queue)
6162
$attempts = $this->_data()['attempts'];
6263
$settings = Plugin::getInstance()->getSettings();
6364
if ($attempts < $settings->maxAttempts) {
64-
Craft::$app->getQueue()
65-
->delay($settings->retryDelay)
66-
->push(new self([
67-
'requestId' => $this->requestId,
68-
]));
65+
Queue::push(new self([
66+
'requestId' => $this->requestId,
67+
]), null, $settings->retryDelay);
6968
}
7069
}
7170
}

0 commit comments

Comments
 (0)