Conversation
Should fix #359
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how configuration lists are constructed in the
AgentTypeScriptableandCapabilityConfigScriptableclasses to improve clarity and efficiency. Instead of using LINQ'sSelectandSelectMany, the code now explicitly iterates through collections and builds the configuration lists step by step. This approach makes the logic clearer and easier to debug, especially for complex nested object creation.Key changes include:
Refactoring of configuration aggregation:
AgentTypeScriptable, replaced LINQ aggregation with explicit loops to build lists of goals, actions, and sensors, improving readability and maintainability.CapabilityConfigScriptable, replaced LINQ-based construction of actions, goals, and sensors with explicit loops and intermediate lists, allowing for clearer logic and easier debugging.Code cleanup:
using System.Linq;directives from bothAgentTypeScriptable.csandCapabilityConfigScriptable.csas LINQ is no longer used.Should fix #359