Skip to content

Commit cbc467a

Browse files
authored
Merge pull request #82 from crashmax-dev/refactor-web
refactor(packages/web): opened instance `fireworks-js`
2 parents b7c89cd + 3ccabc7 commit cbc467a

File tree

2 files changed

+6
-10
lines changed

2 files changed

+6
-10
lines changed

packages/web/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,6 @@
3535
"prepublishOnly": "pnpm build"
3636
},
3737
"dependencies": {
38-
"fireworks-js": "workspace:2.2.0"
38+
"fireworks-js": "workspace:2.2.1"
3939
}
4040
}

packages/web/src/index.ts

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { Fireworks as FireworksJs } from 'fireworks-js'
22
import type { FireworksOptions } from 'fireworks-js'
33

44
class Fireworks extends HTMLElement {
5-
private fireworks!: FireworksJs
5+
public fireworks: FireworksJs
66
private options: FireworksOptions = {}
77

88
static get observedAttributes() {
@@ -38,21 +38,17 @@ class Fireworks extends HTMLElement {
3838
const options = this.getAttribute('options')
3939
if (options) {
4040
try {
41-
this.options = JSON.parse(options) as FireworksOptions
42-
43-
if (this.fireworks) {
44-
this.fireworks.updateOptions(this.options)
45-
}
41+
this.options = JSON.parse(options)
42+
this.fireworks?.updateOptions(this.options)
4643
} catch (err) {
4744
console.error('Attribute `options` failed parsed:', err)
4845
}
4946
}
5047

5148
const style = this.getAttribute('style')
5249
if (style) {
53-
this.shadowRoot!.querySelector('style')!.textContent = `
54-
div { ${style} }
55-
`
50+
this.shadowRoot!.querySelector('style')!
51+
.textContent = `div { ${style} }`
5652
}
5753
}
5854
}

0 commit comments

Comments
 (0)