Skip to content

Commit 10590a0

Browse files
committed
Fix missing installation in npm and re-work pypi publish action
1 parent 873bd4f commit 10590a0

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

.github/workflows/release_javascript.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ jobs:
3434
3535
- name: Build package
3636
working-directory: 'cratedb_sqlparse_js'
37-
run: npm run build
37+
run: npm install && npm run build
3838

3939
- run: npm publish --provenance --access public
4040
working-directory: 'cratedb_sqlparse_js'

.github/workflows/release_python.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ jobs:
77
build:
88
name: Build and publish package to PyPI
99
runs-on: ubuntu-latest
10+
# Specifying a GitHub environment is optional, but strongly encouraged
1011
environment: pypi
1112
permissions:
1213
# IMPORTANT: this permission is mandatory for Trusted Publishing
@@ -38,7 +39,7 @@ jobs:
3839
python -m build
3940
twine check dist/{*.tar.gz,*.whl}
4041
41-
- name: Publish package to PyPI
42-
working-directory: 'cratedb_sqlparse_py'
43-
run: |
44-
python -m twine upload dist/*
42+
- name: Publish package distributions to PyPI
43+
uses: pypa/gh-action-pypi-publish@release/v1
44+
with:
45+
packages-dir: 'cratedb_sqlparse_py'

0 commit comments

Comments
 (0)