Not receiving the rejectedObject in `.error()`

[rabbishuki]

First of all, thanks for this simple and useful piece of code.

I found a little problem.
When rejecting a promise, the object I get in the .error() function is the OnErrorListener object instead of the rejected Object that I sent.

My code (abbreviated) looks like this:

public Promise example() {
    Promise p = new Promise();
    p.reject("new Error");
    return p;
}

example
    .then(res -> handleSuccess(res))
    .error(res -> handleError(res)) // `res` doesn't equal "new Error".

So I dug into your code and changed the following line

android-promise/Promise.java

Line 369 in fda2ba4

handler.post(() -> handleError(onErrorListener));

to:

    handler.post(() -> handleError(rejectedObject)); 

And now it works as expected.

Is that what was supposed to be done?
or did I do something that will bite me back later?

[hadifikri]

First of all, thanks for this simple and useful piece of code.

I found a little problem.
When rejecting a promise, the object I get in the .error() function is the OnErrorListener object instead of the rejected Object that I sent.

My code (abbreviated) looks like this:

public Promise example() {
    Promise p = new Promise();
    p.reject("new Error");
    return p;
}

example
    .then(res -> handleSuccess(res))
    .error(res -> handleError(res)) // `res` doesn't equal "new Error".

So I dug into your code and changed the following line

android-promise/Promise.java

Line 369 in fda2ba4

handler.post(() -> handleError(onErrorListener));

to:

    handler.post(() -> handleError(rejectedObject)); 

And now it works as expected.

Is that what was supposed to be done?
or did I do something that will bite me back later?

android-promise/Promise.java

Line 415 in fda2ba4

handler.post(() -> handleError(onErrorListener));

Needs to change this line too:

 handler.post(() -> handleError(rejectedObject));

[hadifikri]

This code snippet do not work.

...
rejected()
    .then(res->{
       return null;
    }
   .error(err->{
       Log.e("Error",(String)err);
   });
....
private Promise rejected(){
  Promise p = new Promise();
  p.reject("Some error");
  return p;
}

This however, do work.

...
rejected()
   .error(err->{
       Log.e("Error",(String)err);
   });
...

private Promise rejected(){
  Promise p = new Promise();
  p.reject("Some error");
  return p;
}

There is a need to check the isRejected flag in the then method. The modified then:

    public Promise then(OnSuccessListener listener) {
        onSuccessListener = listener;
        child = new Promise();
        if(isRejected){
            if (handler != null) {
                handler.post(() -> handleError(rejectedObject));
            } else {
                new Thread(() -> handleError(rejectedObject)).start();
            }
        }
        if (isResolved) {
            if (handler != null) {
                handler.post(() -> handleSuccess(child, resolvedObject));
            } else {
                new Thread(() -> handleSuccess(child, resolvedObject)).start();
            }
        }
        return child;
    }