Skip to content

Commit 2ad0d53

Browse files
crazyservercrazyserver
committed
MOBILE-4653 ionic: Select the correct element on ion-select ESM version
Reported here: ionic-team/ionic-framework#30481
1 parent fac9a76 commit 2ad0d53

File tree

1 file changed

+63
-1
lines changed

1 file changed

+63
-1
lines changed

‎patches/@ionic+core+8.5.0.patch‎

Lines changed: 63 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,19 @@ index c644264..175df2e 100644
7171
const root = helpers.getElementRoot(baseEl);
7272
const contentEl = root.querySelector('.popover-content');
7373
const referenceSizeEl = trigger || ((_a = ev === null || ev === void 0 ? void 0 : ev.detail) === null || _a === void 0 ? void 0 : _a.ionShadowTarget) || (ev === null || ev === void 0 ? void 0 : ev.target);
74+
diff --git a/node_modules/@ionic/core/dist/cjs/ion-select_3.cjs.entry.js b/node_modules/@ionic/core/dist/cjs/ion-select_3.cjs.entry.js
75+
index eccb0c4..e35156c 100644
76+
--- a/node_modules/@ionic/core/dist/cjs/ion-select_3.cjs.entry.js
77+
+++ b/node_modules/@ionic/core/dist/cjs/ion-select_3.cjs.entry.js
78+
@@ -172,7 +172,7 @@ const Select = class {
79+
const scrollSelectedIntoView = () => {
80+
const indexOfSelected = this.childOpts.findIndex((o) => o.value === this.value);
81+
if (indexOfSelected > -1) {
82+
- const selectedItem = overlay.querySelector(`.select-interface-option:nth-child(${indexOfSelected + 1})`);
83+
+ const selectedItem = overlay.querySelector(`.select-interface-option:nth-of-type(${indexOfSelected + 1})`);
84+
if (selectedItem) {
85+
/**
86+
* Browsers such as Firefox do not
7487
diff --git a/node_modules/@ionic/core/dist/collection/components/popover/animations/ios.enter.js b/node_modules/@ionic/core/dist/collection/components/popover/animations/ios.enter.js
7588
index 84b30ff..528af87 100644
7689
--- a/node_modules/@ionic/core/dist/collection/components/popover/animations/ios.enter.js
@@ -105,6 +118,19 @@ index 603923a..ff10a25 100644
105118
const root = getElementRoot(baseEl);
106119
const contentEl = root.querySelector('.popover-content');
107120
const referenceSizeEl = trigger || ((_a = ev === null || ev === void 0 ? void 0 : ev.detail) === null || _a === void 0 ? void 0 : _a.ionShadowTarget) || (ev === null || ev === void 0 ? void 0 : ev.target);
121+
diff --git a/node_modules/@ionic/core/dist/collection/components/select/select.js b/node_modules/@ionic/core/dist/collection/components/select/select.js
122+
index 51bc22a..68a5eb5 100644
123+
--- a/node_modules/@ionic/core/dist/collection/components/select/select.js
124+
+++ b/node_modules/@ionic/core/dist/collection/components/select/select.js
125+
@@ -165,7 +165,7 @@ export class Select {
126+
const scrollSelectedIntoView = () => {
127+
const indexOfSelected = this.childOpts.findIndex((o) => o.value === this.value);
128+
if (indexOfSelected > -1) {
129+
- const selectedItem = overlay.querySelector(`.select-interface-option:nth-child(${indexOfSelected + 1})`);
130+
+ const selectedItem = overlay.querySelector(`.select-interface-option:nth-of-type(${indexOfSelected + 1})`);
131+
if (selectedItem) {
132+
/**
133+
* Browsers such as Firefox do not
108134
diff --git a/node_modules/@ionic/core/dist/esm/input-shims-3070628a.js b/node_modules/@ionic/core/dist/esm/input-shims-3070628a.js
109135
index cc59b33..2c24dc3 100644
110136
--- a/node_modules/@ionic/core/dist/esm/input-shims-3070628a.js
@@ -182,8 +208,21 @@ index d32e60c..491c281 100644
182208
const root = getElementRoot(baseEl);
183209
const contentEl = root.querySelector('.popover-content');
184210
const referenceSizeEl = trigger || ((_a = ev === null || ev === void 0 ? void 0 : ev.detail) === null || _a === void 0 ? void 0 : _a.ionShadowTarget) || (ev === null || ev === void 0 ? void 0 : ev.target);
211+
diff --git a/node_modules/@ionic/core/dist/esm/ion-select_3.entry.js b/node_modules/@ionic/core/dist/esm/ion-select_3.entry.js
212+
index 1eb51c3..0b889ab 100644
213+
--- a/node_modules/@ionic/core/dist/esm/ion-select_3.entry.js
214+
+++ b/node_modules/@ionic/core/dist/esm/ion-select_3.entry.js
215+
@@ -168,7 +168,7 @@ const Select = class {
216+
const scrollSelectedIntoView = () => {
217+
const indexOfSelected = this.childOpts.findIndex((o) => o.value === this.value);
218+
if (indexOfSelected > -1) {
219+
- const selectedItem = overlay.querySelector(`.select-interface-option:nth-child(${indexOfSelected + 1})`);
220+
+ const selectedItem = overlay.querySelector(`.select-interface-option:nth-of-type(${indexOfSelected + 1})`);
221+
if (selectedItem) {
222+
/**
223+
* Browsers such as Firefox do not
185224
diff --git a/node_modules/@ionic/core/hydrate/index.js b/node_modules/@ionic/core/hydrate/index.js
186-
index 6de5db2..bc73a84 100644
225+
index 6de5db2..ff80abd 100644
187226
--- a/node_modules/@ionic/core/hydrate/index.js
188227
+++ b/node_modules/@ionic/core/hydrate/index.js
189228
@@ -24183,8 +24183,10 @@ const iosEnterAnimation$1 = (baseEl, opts) => {
@@ -212,3 +251,26 @@ index 6de5db2..bc73a84 100644
212251
const root = getElementRoot(baseEl);
213252
const contentEl = root.querySelector('.popover-content');
214253
const referenceSizeEl = trigger || ((_a = ev === null || ev === void 0 ? void 0 : ev.detail) === null || _a === void 0 ? void 0 : _a.ionShadowTarget) || (ev === null || ev === void 0 ? void 0 : ev.target);
254+
@@ -30118,7 +30122,8 @@ class Select {
255+
const scrollSelectedIntoView = () => {
256+
const indexOfSelected = this.childOpts.findIndex((o) => o.value === this.value);
257+
if (indexOfSelected > -1) {
258+
- const selectedItem = overlay.querySelector(`.select-interface-option:nth-child(${indexOfSelected + 1})`);
259+
+
260+
+ const selectedItem = overlay.querySelector(`.select-interface-option:nth-of-type(${indexOfSelected + 1})`);
261+
if (selectedItem) {
262+
/**
263+
* Browsers such as Firefox do not
264+
diff --git a/node_modules/@ionic/core/hydrate/index.mjs b/node_modules/@ionic/core/hydrate/index.mjs
265+
index 2a2b33d..65002bb 100644
266+
--- a/node_modules/@ionic/core/hydrate/index.mjs
267+
+++ b/node_modules/@ionic/core/hydrate/index.mjs
268+
@@ -30114,7 +30114,7 @@ class Select {
269+
const scrollSelectedIntoView = () => {
270+
const indexOfSelected = this.childOpts.findIndex((o) => o.value === this.value);
271+
if (indexOfSelected > -1) {
272+
- const selectedItem = overlay.querySelector(`.select-interface-option:nth-child(${indexOfSelected + 1})`);
273+
+ const selectedItem = overlay.querySelector(`.select-interface-option:nth-of-type(${indexOfSelected + 1})`);
274+
if (selectedItem) {
275+
/**
276+
* Browsers such as Firefox do not

0 commit comments

Comments
 (0)