Merge pull request moodlehq#4468 from crazyserver/MOBILE-3063

Mobile 3063

Author: dpalou

src/addons/mod/bigbluebuttonbn/tests/behat/basic_usage.feature

@@ -173,5 +173,7 @@ Feature: Test basic usage of BBB activity in app
     When I press "Presentation" in the app
     And I press "OK" in the app
     And I switch to the browser tab opened by the app
-    And I log in as "student1"
-    Then I should see "The recording URL is invalid"
+    # This part fails due to an issue in LSM.
+    # @TODO Uncomment when MDL-85704 is solved
+    # And I log in as "student1"
+    # Then I should see "The recording URL is invalid"

src/core/directives/format-text.ts

@@ -997,7 +997,7 @@ export class CoreFormatTextDirective implements OnChanges, OnDestroy, AsyncDirec
     protected addIframeHelp(iframe: HTMLIFrameElement): void {
         const helpDiv = document.createElement('div');
 
-        helpDiv.classList.add('ion-text-center', 'ion-text-wrap');
+        helpDiv.classList.add('ion-text-center', 'ion-text-wrap', 'core-iframe-help');
 
         const button = document.createElement('ion-button');
         button.setAttribute('fill', 'clear');

src/core/directives/reading-mode.ts

@@ -67,7 +67,7 @@ export class CoreReadingModeDirective implements AfterViewInit, OnDestroy {
         await this.addTextViewerButton();
         this.element.classList.add('core-reading-mode-ready');
 
-        this.enabled = document.body.classList.contains('core-reading-mode-enabled');
+        this.enabled = document.body.classList.contains('core-reading-mode-enable-on-enter');
         if (this.enabled) {
             await this.enterReadingMode();
         }
@@ -136,6 +136,7 @@ export class CoreReadingModeDirective implements AfterViewInit, OnDestroy {
         await this.header?.setEnabled(false);
 
         document.body.classList.add('core-reading-mode-enabled');
+        document.body.classList.add('core-reading-mode-enable-on-enter');
 
         const elements = document.body.querySelectorAll('[core-reading-mode].core-reading-mode-ready');
 
@@ -185,6 +186,7 @@ export class CoreReadingModeDirective implements AfterViewInit, OnDestroy {
 
         this.enabled = false;
         document.body.classList.remove('core-reading-mode-enabled');
+        document.body.classList.remove('core-reading-mode-enable-on-enter');
 
         // Enable all styles in element.
         this.disabledStyles.forEach((style) => {
@@ -236,6 +238,7 @@ export class CoreReadingModeDirective implements AfterViewInit, OnDestroy {
         this.viewportPromise?.cancel();
 
         // Disable reading mode should be done by the user.
+        document.body.classList.remove('core-reading-mode-enabled');
     }
 
 }

src/theme/components/reading-mode.scss

@@ -12,26 +12,30 @@ body.core-reading-mode-enabled {
     &.core-reading-mode-theme-light {
         --reading-mode-background: #{$background-color};
         --reading-mode-text-color: #{$text-color};
+        --reading-mode-link-color: var(--info);
     }
 
     &.core-reading-mode-theme-dark {
         --reading-mode-background: #{$background-color-dark};
         --reading-mode-text-color: #{$text-color-dark};
+        --reading-mode-link-color: var(--info-tint);
     }
 
     &.core-reading-mode-theme-sepia {
         --reading-mode-background: var(--core-reading-mode-sepia-background);
         --reading-mode-text-color: var(--core-reading-mode-sepia-text-color);
+        --reading-mode-link-color: var(--info);
     }
 
     &.core-reading-mode-theme-hcm {
         --reading-mode-background: #000000;
         --reading-mode-text-color: #ffffff;
+        --reading-mode-link-color: var(--info-tint);
     }
 
     &.core-reading-mode-multimedia-hidden {
         ion-content.core-reading-mode-content {
-            img, video, iframe {
+            img, video, iframe, core-iframe, .core-iframe-help {
                 display: none !important;
             }
         }
@@ -49,6 +53,7 @@ body.core-reading-mode-enabled {
                 --color: var(--reading-mode-text-color, --text-color);
                 --subdued-text-color: var(--text-color);
                 --core-input-text: var(--text-color);
+                --core-link-color: var(--reading-mode-link-color, --core-link-color);
                 color: var(--text-color) !important;
             }