suggestions

Author: henderkes

src/SPC/builder/Extension.php

@@ -10,8 +10,6 @@
 use SPC\exception\WrongUsageException;
 use SPC\store\Config;
 use SPC\store\FileSystem;
-use SPC\toolchain\ToolchainManager;
-use SPC\toolchain\ZigToolchain;
 use SPC\util\SPCConfigUtil;
 use SPC\util\SPCTarget;
 
@@ -429,17 +427,13 @@ public function buildUnixShared(): void
             logger()->info("Extension [{$this->getName()}] patched before shared configure");
         }
 
-        $has_avx512 = str_contains($this->builder->arch_c_flags ?? '', '-mavx512') ||
-            str_contains($this->arch_c_flags ?? '', '-march=x86-64-v4') ||
-            ToolchainManager::getToolchainClass() !== ZigToolchain::class;
-
         shell()->cd($this->source_dir)
             ->setEnv($env)
             ->appendEnv($this->getExtraEnv())
             ->exec(
                 './configure ' . $this->getUnixConfigureArg(true) .
                 ' --with-php-config=' . BUILD_BIN_PATH . '/php-config ' .
-                '--enable-shared --disable-static' . (!$has_avx512 ? ' php_cv_have_avx512=no php_cv_have_avx512vbmi=no' : '')
+                '--enable-shared --disable-static ' . getenv('SPC_EXTRA_PHP_VARS')
             );
 
         if ($this->patchBeforeSharedMake()) {

src/SPC/builder/linux/LinuxBuilder.php

@@ -9,8 +9,6 @@
 use SPC\exception\WrongUsageException;
 use SPC\store\FileSystem;
 use SPC\store\SourcePatcher;
-use SPC\toolchain\ToolchainManager;
-use SPC\toolchain\ZigToolchain;
 use SPC\util\GlobalEnvManager;
 use SPC\util\SPCConfigUtil;
 use SPC\util\SPCTarget;
@@ -105,10 +103,6 @@ public function buildPHP(int $build_target = BUILD_TARGET_NONE): void
             );
         }
 
-        $has_avx512 = str_contains($this->arch_c_flags, '-mavx512') ||
-            str_contains($this->arch_c_flags, '-march=x86-64-v4') ||
-            ToolchainManager::getToolchainClass() !== ZigToolchain::class;
-
         $this->seekPhpSrcLogFileOnException(fn () => shell()->cd(SOURCE_PATH . '/php-src')->exec(
             $php_configure_env . ' ' .
                 getenv('SPC_CMD_PREFIX_PHP_CONFIGURE') . ' ' .
@@ -122,7 +116,7 @@ public function buildPHP(int $build_target = BUILD_TARGET_NONE): void
                 $json_74 .
                 $zts .
                 $maxExecutionTimers .
-                (!$has_avx512 ? 'php_cv_have_avx512=no php_cv_have_avx512vbmi=no ' : '') .
+                getenv('SPC_EXTRA_PHP_VARS') . ' ' .
                 $this->makeStaticExtensionArgs() . ' '
         ));
 

src/SPC/toolchain/ZigToolchain.php

@@ -64,6 +64,11 @@ public function afterInit(): void
             $extra_libs = trim($extra_libs . ' -lunwind');
             GlobalEnvManager::putenv("SPC_EXTRA_LIBS={$extra_libs}");
         }
+        $cflags = getenv('SPC_DEFAULT_C_FLAGS') ?: getenv('CFLAGS') ?: '';
+        $has_avx512 = str_contains($cflags, '-mavx512') || str_contains($cflags, '-march=x86-64-v4');
+        if (!$has_avx512) {
+            f_putenv('SPC_EXTRA_PHP_VARS=php_cv_have_avx512=no php_cv_have_avx512vbmi=no');
+        }
     }
 
     public function getCompilerInfo(): ?string