add extra features to librdkafka (curl, ssl, sasl

Author: henderkes

config/lib.json

@@ -513,6 +513,10 @@
         ],
         "cpp-library": true,
         "lib-suggests": [
+            "curl",
+            "liblz4",
+            "openssl",
+            "zlib",
             "zstd"
         ]
     },

src/SPC/builder/extension/rdkafka.php

@@ -15,6 +15,7 @@ public function patchBeforeBuildconf(): bool
     {
         FileSystem::replaceFileStr("{$this->source_dir}/config.m4", "-L\$RDKAFKA_DIR/\$PHP_LIBDIR -lm\n", "-L\$RDKAFKA_DIR/\$PHP_LIBDIR -lm \$RDKAFKA_LIBS\n");
         FileSystem::replaceFileStr("{$this->source_dir}/config.m4", "-L\$RDKAFKA_DIR/\$PHP_LIBDIR -lm\"\n", '-L$RDKAFKA_DIR/$PHP_LIBDIR -lm $RDKAFKA_LIBS"');
+        FileSystem::replaceFileStr("{$this->source_dir}/config.m4", 'PHP_CHECK_LIBRARY($LIBNAME,$LIBSYMBOL,', 'AC_CHECK_LIB([$LIBNAME], [$LIBSYMBOL],');
         return true;
     }
 
@@ -39,6 +40,9 @@ public function getUnixConfigureArg(bool $shared = false): string
     {
         $pkgconf_libs = shell()->execWithResult('pkg-config --libs --static rdkafka')[1];
         $pkgconf_libs = trim(implode('', $pkgconf_libs));
+        $pkgconf_libs = str_replace(BUILD_LIB_PATH . '/lib', '-l', $pkgconf_libs);
+        $pkgconf_libs = str_replace('.a', '', $pkgconf_libs);
+        $pkgconf_libs = deduplicate_flags($pkgconf_libs);
         return '--with-rdkafka=' . ($shared ? 'shared,' : '') . BUILD_ROOT_PATH . ' RDKAFKA_LIBS="' . $pkgconf_libs . '"';
     }
 }

src/SPC/builder/unix/library/librdkafka.php

@@ -32,20 +32,28 @@ protected function build(): void
                 'zstd',
                 function ($lib) {
                     putenv("STATIC_LIB_libzstd={$lib->getLibDir()}/libzstd.a");
-                    return '';
+                    return '--enable-zstd';
                 },
                 '--disable-zstd'
             )
+            ->optionalLib(
+                'curl',
+                function () {
+                    $pkg_libs = shell()->execWithResult('pkg-config --libs --static libcurl')[1];
+                    putenv("STATIC_LIB_libcurl={$pkg_libs}");
+                    return '--enable-curl';
+                },
+                '--disable-curl'
+            )
+            ->optionalLib('openssl', '--enable-ssl', '--disable-ssl')
+            ->optionalLib('zlib', '--enable-zlib', '--disable-zlib')
             ->removeConfigureArgs(
                 '--with-pic',
                 '--enable-pic',
             )
             ->configure(
-                '--disable-curl',
                 '--disable-sasl',
                 '--disable-valgrind',
-                '--disable-zlib',
-                '--disable-ssl',
             )
             ->make();