Skip to content

Commit 5cd987b

Browse files
authored
since we explicitly delete module folder before building, we should reintroduce this check (#783)
otherwise shared extensions that other shared extensions depend on will be built multiple times
1 parent 8293160 commit 5cd987b

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/SPC/builder/Extension.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -342,6 +342,9 @@ public function buildShared(): void
342342
return;
343343
}
344344
}
345+
if (file_exists(BUILD_MODULES_PATH . '/' . $this->getName() . '.so')) {
346+
logger()->info('Shared extension [' . $this->getName() . '] was already built, skipping (' . $this->getName() . '.so)');
347+
}
345348
logger()->info('Building extension [' . $this->getName() . '] as shared extension (' . $this->getName() . '.so)');
346349
foreach ($this->dependencies as $dependency) {
347350
if (!$dependency instanceof Extension) {

0 commit comments

Comments
 (0)