move enable zts check

Author: henderkes

src/SPC/builder/BuilderBase.php

@@ -513,7 +513,10 @@ public function emitPatchPoint(string $point_name): void
     public function checkBeforeBuildPHP(int $rule): void
     {
         if (($rule & BUILD_TARGET_FRANKENPHP) === BUILD_TARGET_FRANKENPHP) {
-            // frankenphp only support linux and macOS
+            if (!$this->getOption('enable-zts')) {
+                throw new WrongUsageException('FrankenPHP SAPI requires ZTS enabled PHP, build with `--enable-zts`!');
+            }
+            // frankenphp doesn't support windows, BSD is currently not supported by static-php-cli
             if (!in_array(PHP_OS_FAMILY, ['Linux', 'Darwin'])) {
                 throw new WrongUsageException('FrankenPHP SAPI is only available on Linux and macOS!');
             }
@@ -523,9 +526,9 @@ public function checkBeforeBuildPHP(int $rule): void
                 global $argv;
                 throw new WrongUsageException("FrankenPHP SAPI requires go-mod-frankenphp package, please install it first: {$argv[0]} install-pkg go-mod-frankenphp");
             }
-            // frankenphp needs libxml2 libs
+            // frankenphp needs libxml2 lib on macos, see: https://github.com/php/frankenphp/blob/main/frankenphp.go#L17
             if (PHP_OS_FAMILY === 'Darwin' && !$this->getLib('libxml2')) {
-                throw new WrongUsageException('FrankenPHP SAPI for macOS requires libxml2 library, please include `xml` extension in your build.');
+                throw new WrongUsageException('FrankenPHP SAPI for macOS requires libxml2 library, please include the `xml` extension in your build.');
             }
         }
     }

src/SPC/command/BuildPHPCommand.php

@@ -304,13 +304,6 @@ private function parseRules(array $shared_extensions = []): int
             $rule |= BUILD_TARGET_EMBED;
             f_putenv('SPC_CMD_VAR_PHP_EMBED_TYPE=' . ($embed === 'static' ? 'static' : 'shared'));
         }
-        if ($this->getOption('build-frankenphp')) {
-            $rule |= BUILD_TARGET_FRANKENPHP;
-            if (!$this->getOption('enable-zts')) {
-                logger()->warning('FrankenPHP requires ZTS to work with multiple threads, the --enable-zts option will be enabled automatically!');
-                $this->input->setOption('enable-zts', true);
-            }
-        }
         $rule |= ($this->getOption('build-frankenphp') ? (BUILD_TARGET_FRANKENPHP | BUILD_TARGET_EMBED) : BUILD_TARGET_NONE);
         $rule |= ($this->getOption('build-all') ? BUILD_TARGET_ALL : BUILD_TARGET_NONE);
         return $rule;