Skip to content

Commit b9f8f02

Browse files
committed
don't use libicu backend for libxml2
(it's discouraged from being used, the first path always goes through iconv, icu is only the fallback)
1 parent c330d02 commit b9f8f02

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

config/lib.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -450,6 +450,7 @@
450450
},
451451
"libmemcached": {
452452
"source": "libmemcached",
453+
"cpp-library": true,
453454
"static-libs-unix": [
454455
"libmemcached.a",
455456
"libmemcachedprotocol.a",
@@ -594,7 +595,6 @@
594595
],
595596
"lib-suggests-unix": [
596597
"xz",
597-
"icu",
598598
"zlib"
599599
],
600600
"lib-depends-windows": [

src/SPC/builder/unix/library/libxml2.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@ public function build(): void
2020
"-DZLIB_INCLUDE_DIR={$this->getIncludeDir()}",
2121
'-DLIBXML2_WITH_ZLIB=OFF',
2222
)
23-
->optionalLib('icu', ...cmake_boolean_args('LIBXML2_WITH_ICU'))
2423
->optionalLib('xz', ...cmake_boolean_args('LIBXML2_WITH_LZMA'))
2524
->addConfigureArgs(
2625
'-DLIBXML2_WITH_ICONV=ON',
26+
'-DLIBXML2_WITH_ICU=OFF', // optional, but discouraged: https://gitlab.gnome.org/GNOME/libxml2/-/blob/master/README.md
2727
'-DLIBXML2_WITH_PYTHON=OFF',
2828
'-DLIBXML2_WITH_PROGRAMS=OFF',
2929
'-DLIBXML2_WITH_TESTS=OFF',

0 commit comments

Comments
 (0)