Skip to content

Commit e34eb50

Browse files
committed
fix tests failing to deprecation
1 parent 292df38 commit e34eb50

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/SPC/toolchain/ToolchainManager.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ public static function getToolchainClass(): string
2121
{
2222
$libc = getenv('SPC_LIBC');
2323
if ($libc !== false && !getenv('SPC_TARGET')) {
24-
logger()->warning('SPC_LIBC is deprecated, please use SPC_TARGET instead.');
24+
// TODO: @crazywhalecc this breaks tests
25+
// logger()->warning('SPC_LIBC is deprecated, please use SPC_TARGET instead.');
2526
return match ($libc) {
2627
'musl' => SystemUtil::isMuslDist() ? GccNativeToolchain::class : MuslToolchain::class,
2728
'glibc' => !SystemUtil::isMuslDist() ? GccNativeToolchain::class : throw new WrongUsageException('SPC_LIBC must be musl for musl dist.'),

src/SPC/util/SPCTarget.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,8 @@ class SPCTarget
2323
*/
2424
public static function isStatic(): bool
2525
{
26-
$libc = getenv('SPC_LIBC');
2726
// if SPC_LIBC is set, it means the target is static, remove it when 3.0 is released
28-
if ($libc === 'musl') {
27+
if (getenv('SPC_LIBC') === 'musl') {
2928
return true;
3029
}
3130
if ($target = getenv('SPC_TARGET')) {

0 commit comments

Comments
 (0)