Merge pull request #120 from dasuken/master

Implement getAbsoluteUrl function to abort the difference  in incoming url when use -t option

Author: koddr

pkg/cgapp/git.go

@@ -6,8 +6,10 @@ package cgapp
 
 import (
 	"fmt"
+	"net/url"
 	"os"
 	"path/filepath"
+	"strings"
 
 	"github.com/go-git/go-git/v5"
 )
@@ -30,7 +32,7 @@ func GitClone(templateType, templateURL string) error {
 		folder,
 		false,
 		&git.CloneOptions{
-			URL: fmt.Sprintf("https://%s", templateURL),
+			URL: getAbsoluteURL(templateURL),
 		},
 	)
 	if errPlainClone != nil {
@@ -44,3 +46,14 @@ func GitClone(templateType, templateURL string) error {
 
 	return nil
 }
+
+func getAbsoluteURL(templateURL string) string {
+	templateURL = strings.TrimSpace(templateURL)
+	u, _ := url.Parse(templateURL)
+
+	if len(u.Scheme) == 0 {
+		u.Scheme = "https"
+	}
+
+	return u.String()
+}

pkg/cgapp/git_test.go

@@ -59,3 +59,44 @@ func TestGitClone(t *testing.T) {
 		}
 	}
 }
+
+func Test_getAbsoluteURL(t *testing.T) {
+	type args struct {
+		templateURL   string
+	}
+	tests := []struct {
+		name    string
+		args    args
+		want string
+	}{
+		{
+			"successfully get absolute url from url with scheme",
+			args{
+				templateURL: "https://github.com/create-go-app/net_http-go-template",
+			},
+			"https://github.com/create-go-app/net_http-go-template",
+		},
+		{
+			"successfully get absolute url from url without scheme",
+			args{
+				templateURL: "github.com/create-go-app/net_http-go-template",
+			},
+			"https://github.com/create-go-app/net_http-go-template",
+		},
+		{
+			"successfully get absolute url from url starting space",
+			args{
+				templateURL: " github.com/create-go-app/net_http-go-template",
+			},
+			"https://github.com/create-go-app/net_http-go-template",
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			if got := getAbsoluteURL(tt.args.templateURL); got != tt.want {
+				t.Errorf("getAbsoluteURL() = %v, want %v", got, tt.want)
+			}
+		})
+	}
+}

pkg/registry/defaults.go

@@ -111,15 +111,13 @@ var (
 			Name: "backend",
 			Prompt: &survey.Input{
 				Message: "Enter URL to the custom backend repository:",
-				Help:    "No need to specify `http://` or `https://` protocol.",
 			},
 			Validate: survey.Required,
 		},
 		{
 			Name: "frontend",
 			Prompt: &survey.Input{
 				Message: "Enter URL to the custom frontend repository:",
-				Help:    "No need to specify `http://` or `https://` protocol.",
 				Default: "none",
 			},
 		},