Skip to content

Commit f7a5baa

Browse files
author
maps2002
committed
Fix when writing job execution status.
1 parent 8bf207e commit f7a5baa

File tree

3 files changed

+25
-21
lines changed

3 files changed

+25
-21
lines changed

DatabaseModel/App.Config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<section name="entityFramework" type="System.Data.Entity.Internal.ConfigFile.EntityFrameworkSection, EntityFramework, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089" requirePermission="false" />
66
<!-- For more information on Entity Framework configuration, visit http://go.microsoft.com/fwlink/?LinkID=237468 --></configSections>
77
<connectionStrings>
8-
<add name="CSPDatabaseModelEntities" connectionString="metadata=res://*/CSPDatabaseModelEntities.csdl|res://*/CSPDatabaseModelEntities.ssdl|res://*/CSPDatabaseModelEntities.msl;provider=System.Data.SqlClient;provider connection string=&quot;data source=maps-pc\sqlexpress;initial catalog=Create.CSP.Reporting;integrated security=True;MultipleActiveResultSets=True;App=EntityFramework&quot;" providerName="System.Data.EntityClient" />
8+
<add name="CSPDatabaseModelEntities" connectionString="metadata=res://*/CSPDatabaseModelEntities.csdl|res://*/CSPDatabaseModelEntities.ssdl|res://*/CSPDatabaseModelEntities.msl;provider=System.Data.SqlClient;provider connection string=&quot;data source=localhost\sqlexpress;initial catalog=Create.CSP.Reporting;integrated security=True;MultipleActiveResultSets=True;App=EntityFramework&quot;" providerName="System.Data.EntityClient" />
99
</connectionStrings>
1010
<entityFramework>
1111
<defaultConnectionFactory type="System.Data.Entity.Infrastructure.SqlConnectionFactory, EntityFramework" />

DatabaseModel/Managers/CorrelationIdsManager.cs

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,13 @@ public CorrelationIdsManager(DbContext dbContext = null)
1616
}
1717

1818
#region Create
19-
19+
2020
private async Task<CorrelationId> AddAsync(CorrelationId correlationId)
2121
{
22-
using (var dbContext = new CSPDatabaseModelEntities())
23-
{
24-
CorrelationId newCorrelationId = dbContext.CorrelationIds.Add(correlationId);
25-
await dbContext.SaveChangesAsync();
22+
CorrelationId newCorrelationId = _dbContext.CorrelationIds.Add(correlationId);
23+
await _dbContext.SaveChangesAsync();
2624

27-
return newCorrelationId;
28-
}
25+
return newCorrelationId;
2926
}
3027

3128
public Task<CorrelationId> AddNewRunAsync()
@@ -35,7 +32,7 @@ public Task<CorrelationId> AddNewRunAsync()
3532
Id = Guid.NewGuid(),
3633
StartDateTime = DateTime.UtcNow,
3734
Status = "RUNNING",
38-
EndDateTime = null
35+
EndDateTime = null
3936
});
4037
}
4138

@@ -45,25 +42,28 @@ public Task<CorrelationId> AddNewRunAsync()
4542

4643
private async Task<CorrelationId> UpdateAsync(CorrelationId correlationId)
4744
{
48-
using (var dbContext = new CSPDatabaseModelEntities())
49-
{
50-
dbContext.Entry(correlationId).State = EntityState.Modified;
51-
await dbContext.SaveChangesAsync();
5245

53-
return correlationId;
54-
}
46+
_dbContext.Entry(correlationId).State = EntityState.Modified;
47+
await _dbContext.SaveChangesAsync();
48+
return correlationId;
5549
}
5650

5751
public Task<CorrelationId> UpdateEndStatusAsync(Guid correlationId, string endStatus)
5852
{
59-
CorrelationId databaseCorrelationId = new CorrelationId()
53+
54+
// Get object to update
55+
var existentCorrelation = _dbContext.CorrelationIds.FirstOrDefault(c => c.Id == correlationId);
56+
if (existentCorrelation == null)
6057
{
61-
Id = correlationId,
62-
EndDateTime = DateTime.UtcNow,
63-
Status = endStatus
64-
};
58+
throw new ArgumentException("Could not find existent correlation id: " + correlationId);
59+
}
60+
61+
// else. Update
62+
existentCorrelation.EndDateTime = DateTime.UtcNow;
63+
existentCorrelation.Status = endStatus;
64+
65+
return this.UpdateAsync(existentCorrelation);
6566

66-
return this.UpdateAsync(databaseCorrelationId);
6767
}
6868

6969
#endregion

Job/Processors/ActivationReportProcessor.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -625,6 +625,10 @@ protected override async Task OutputToDatabaseBatchAsync(BlockingCollection<Repo
625625
}
626626
finally
627627
{
628+
//if (capturedException != null)
629+
//{
630+
// capturedException.Throw();
631+
//}
628632
}
629633
}
630634

0 commit comments

Comments
 (0)