Skip to content

Commit 6507537

Browse files
Fix lint (#19)
* 🚨 Remove the lint about non nullable binding instances * 🔥 Remove _ambiguate * Revert changes to pubspec.lock * :see_no_devil: Add pubspeck.lock to gitignore * 📝 Update the version number * 🎨 Remove unecessary formatting * Apply suggestions from code review Co-authored-by: creativecreatorormaybenot <creativecreatorormaybenot@gmail.com>
1 parent dfd5d46 commit 6507537

File tree

5 files changed

+28
-23
lines changed

5 files changed

+28
-23
lines changed

performance/.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
.pub-cache/
3030
.pub/
3131
build/
32+
pubspec.lock
3233

3334
# Android related
3435
**/android/**/gradle-wrapper.jar

performance/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 0.1.1
2+
3+
* Fixed warnings introduced by Flutter 3 (`SchedulerBinding.instance` is now non-nullable).
4+
15
## 0.1.0+1
26

37
* Extended package description.

performance/example/pubspec.lock

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ packages:
77
name: async
88
url: "https://pub.dartlang.org"
99
source: hosted
10-
version: "2.8.1"
10+
version: "2.8.2"
1111
boolean_selector:
1212
dependency: transitive
1313
description:
@@ -21,7 +21,7 @@ packages:
2121
name: characters
2222
url: "https://pub.dartlang.org"
2323
source: hosted
24-
version: "1.1.0"
24+
version: "1.2.0"
2525
charcode:
2626
dependency: transitive
2727
description:
@@ -42,14 +42,14 @@ packages:
4242
name: collection
4343
url: "https://pub.dartlang.org"
4444
source: hosted
45-
version: "1.15.0"
45+
version: "1.16.0"
4646
fake_async:
4747
dependency: transitive
4848
description:
4949
name: fake_async
5050
url: "https://pub.dartlang.org"
5151
source: hosted
52-
version: "1.2.0"
52+
version: "1.3.0"
5353
flutter:
5454
dependency: "direct main"
5555
description: flutter
@@ -85,7 +85,7 @@ packages:
8585
name: js
8686
url: "https://pub.dartlang.org"
8787
source: hosted
88-
version: "0.6.3"
88+
version: "0.6.4"
8989
lints:
9090
dependency: transitive
9191
description:
@@ -99,7 +99,14 @@ packages:
9999
name: matcher
100100
url: "https://pub.dartlang.org"
101101
source: hosted
102-
version: "0.12.10"
102+
version: "0.12.11"
103+
material_color_utilities:
104+
dependency: transitive
105+
description:
106+
name: material_color_utilities
107+
url: "https://pub.dartlang.org"
108+
source: hosted
109+
version: "0.1.4"
103110
meta:
104111
dependency: transitive
105112
description:
@@ -113,14 +120,14 @@ packages:
113120
name: path
114121
url: "https://pub.dartlang.org"
115122
source: hosted
116-
version: "1.8.0"
123+
version: "1.8.1"
117124
performance:
118125
dependency: "direct main"
119126
description:
120127
path: ".."
121128
relative: true
122129
source: path
123-
version: "0.1.0"
130+
version: "0.1.1"
124131
plugin_platform_interface:
125132
dependency: transitive
126133
description:
@@ -139,7 +146,7 @@ packages:
139146
name: source_span
140147
url: "https://pub.dartlang.org"
141148
source: hosted
142-
version: "1.8.1"
149+
version: "1.8.2"
143150
stack_trace:
144151
dependency: transitive
145152
description:
@@ -174,14 +181,7 @@ packages:
174181
name: test_api
175182
url: "https://pub.dartlang.org"
176183
source: hosted
177-
version: "0.4.2"
178-
typed_data:
179-
dependency: transitive
180-
description:
181-
name: typed_data
182-
url: "https://pub.dartlang.org"
183-
source: hosted
184-
version: "1.3.0"
184+
version: "0.4.9"
185185
url_launcher:
186186
dependency: "direct main"
187187
description:
@@ -237,7 +237,7 @@ packages:
237237
name: vector_math
238238
url: "https://pub.dartlang.org"
239239
source: hosted
240-
version: "2.1.0"
240+
version: "2.1.2"
241241
sdks:
242-
dart: ">=2.14.0 <3.0.0"
242+
dart: ">=2.17.0-0 <3.0.0"
243243
flutter: ">=2.5.0"

performance/lib/src/overlay.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -220,12 +220,12 @@ class _CustomPerformanceOverlayState extends State<_CustomPerformanceOverlay> {
220220
@override
221221
void initState() {
222222
super.initState();
223-
SchedulerBinding.instance!.addTimingsCallback(_timingsCallback);
223+
SchedulerBinding.instance.addTimingsCallback(_timingsCallback);
224224
}
225225

226226
@override
227227
void dispose() {
228-
SchedulerBinding.instance!.removeTimingsCallback(_timingsCallback);
228+
SchedulerBinding.instance.removeTimingsCallback(_timingsCallback);
229229
super.dispose();
230230
}
231231

@@ -248,7 +248,7 @@ class _CustomPerformanceOverlayState extends State<_CustomPerformanceOverlay> {
248248
// Furthermore, this prevents indefinite rebuilds on desktop as setting
249249
// state after the timings callback triggers another timings callback but
250250
// doing so in a post frame callback somehow does not.
251-
SchedulerBinding.instance!.addPostFrameCallback((timeStamp) {
251+
SchedulerBinding.instance.addPostFrameCallback((timeStamp) {
252252
if (!mounted) return;
253253
setState(() {
254254
_samples = combinedSamples.sublist(max(

performance/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: performance
22
description: Performance overlay package for Flutter apps that works on web.
3-
version: 0.1.0+1
3+
version: 0.1.1
44
homepage: https://github.com/creativecreatorormaybenot/performance/tree/main/performance
55

66
environment:

0 commit comments

Comments
 (0)