Skip to content

Commit 01de14b

Browse files
author
Jevgeni Koltšin
committed
handle s3 response status
1 parent 739c140 commit 01de14b

File tree

3 files changed

+14
-7
lines changed

3 files changed

+14
-7
lines changed

src/main/java/com/creatubbles/api/core/CreatubblesRequest.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,11 @@ public boolean wasSuccessful() {
131131
}
132132

133133
private boolean isSuccessStatus(Response response) {
134-
return response.getStatus() == 200 || response.getStatus() == 204;
134+
return isSuccessStatusCode(response.getStatus());
135+
}
136+
137+
public boolean isSuccessStatusCode(int status) {
138+
return status == 200 || status == 204;
135139
}
136140

137141
public void cancelRequest() {
@@ -265,4 +269,7 @@ public void setResponse(Response response) {
265269
this.response = response;
266270
}
267271

272+
public void setResponseCache(T responseCache) {
273+
this.responseCache = responseCache;
274+
}
268275
}

src/main/java/com/creatubbles/api/request/amazon/UploadS3ImageRequest.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,16 +30,14 @@ public Class<? extends UploadS3ImageResponse> getResponseClass() {
3030
@Override
3131
public CreatubblesRequest<UploadS3ImageResponse> execute() {
3232
resetResponse();
33+
UploadS3ImageResponse response = new UploadS3ImageResponse();
3334
try {
34-
HttpUtil.uploadObject(data, url);
35+
response.success = isSuccessStatusCode(HttpUtil.uploadObject(data, url));
36+
setResponseCache(response);
3537
} catch (IOException e) {
3638
e.printStackTrace();
3739
}
3840
return this;
3941
}
4042

41-
@Override
42-
public UploadS3ImageResponse getResponse() {
43-
return new UploadS3ImageResponse();
44-
}
45-
}
43+
}

src/main/java/com/creatubbles/api/response/amazon/UploadS3ImageResponse.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,6 @@
66
* Created by Jevgeni on 28.10.2015.
77
*/
88
public class UploadS3ImageResponse extends CreatubblesResponse {
9+
10+
public boolean success;
911
}

0 commit comments

Comments
 (0)