mocp api with sinatra and simulate a 404

Author: Andrej Jančič

lib/creatubbles/base_collection.rb

@@ -13,9 +13,15 @@ def initialize(connection)
     @connection = connection
   end
 
-  def find(id)
+  def find(id,opts={nil_404:false})
     res = @connection.get("#{self.class.type_name}/#{id}")
     Creatubbles.instantiate_object_from_response(res, @connection)
+  rescue => e
+    if opts[:nil_404] && is_record_not_found_404?(e)
+      return nil
+    else
+      raise e
+    end
   end
 
   def init_objects(response)
@@ -26,4 +32,15 @@ def handle_params(params_hash={}, allowed_params=['query','filter'])
     params_hash.stringify_keys!.slice!(allowed_params).to_param
   end
 
+  private
+
+  def is_record_not_found_404?(e)
+    return false unless e.is_a?(OAuth2::Error)
+    body = e&.response&.body
+    return false unless body
+    resp = JSON.parse(e.response.body) rescue nil
+    return false unless resp
+    resp['errors'] && resp['errors'].any? { |err| err['status'].to_i == 404  }
+  end
+
 end

spec/creatubbles/base_collection_spec.rb

@@ -0,0 +1,14 @@
+require 'spec_helper'
+
+RSpec.describe Creatubbles::BaseCollection do
+
+  it "ignores deleted creation" do
+    client = Creatubbles::Client.dummy
+
+    expect{client.test_objects.find('non-existing-object-id')}.
+      to raise_error(OAuth2::Error)
+
+    expect{client.test_objects.find('non-existing-object-id', nil_404:true)}.
+      not_to raise_error
+  end
+end

spec/creatubbles/creation_spec.rb

@@ -1,4 +1,4 @@
-require 'helper'
+require 'spec_helper'
 
 describe Creatubbles::Creation do
   let(:client) { Creatubbles::Client.new }

spec/creatubbles/user_spec.rb

@@ -1,4 +1,4 @@
-require 'helper'
+require 'spec_helper'
 
 describe Creatubbles::User do
   let(:client) { Creatubbles::Client.new }

spec/helper.rb renamed to spec/spec_helper.rb

@@ -1,12 +1,21 @@
 require 'oauth2'
 require 'rspec'
 require 'creatubbles'
+require 'sinatra/base'
+require 'webmock/rspec'
+require 'pry'
 
 Dir['spec/support/**/*.rb'].each do |f|
   require f.gsub('spec/', '').gsub('.rb', '')
 end
 
+WebMock.disable_net_connect!(allow_localhost: true)
+
 RSpec.configure do |config|
+  config.before(:each) do
+    stub_request(:any, /api.creatubbles.com/).to_rack(Creatubbles::MockAPI)
+  end
+
   config.expect_with :rspec do |c|
     c.syntax = :expect
   end

spec/support/creatubbles_mock_api.rb

@@ -0,0 +1,34 @@
+require 'spec_helper'
+
+module Creatubbles
+  class MockAPI < Sinatra::Base
+    set :port, 3000
+
+    # put class variables here
+    # you cannot use @var in Sinatra::Base
+    configure do
+    end
+
+    # return a preset access token
+    post '/oauth/token' do
+      headers "Content-Type" => 'application/json'
+      {"access_token" => "a8c814aa3cee2d5cdca997a314dca206335c119e7121e954a7c6f17592caa33d", "token_type" => "bearer", "created_at" => 1479918313}.to_json
+    end
+
+    post '/v2/oauth/token' do
+      headers "Content-Type" => 'application/json'
+      {"access_token" => "a8c814aa3cee2d5cdca997a314dca206335c119e7121e954a7c6f17592caa33d", "token_type" => "bearer", "created_at" => 1479918313}.to_json
+    end
+
+    # get a non existing object
+    get '/v2/test_objects/non-existing-object-id' do
+      status 404
+      headers "Content-Type" => 'application/json'
+      "{\"errors\":[{\"status\":\"404\",\"code\":\"not_found\",\"source\":\"https://api.creatubbles.com/v2/objects/non-existing-creation-id\",\"title\":\"Not found\",\"detail\":\"Record not found\"}]}"
+    end
+
+  end
+end
+
+# To run the moch as a separate process:
+# Creatubbles::MockAPI.run!

spec/support/dummy_client.rb

@@ -0,0 +1,22 @@
+module Creatubbles
+  class Client
+
+    def self.dummy_auth_details
+      {
+        client_id: "dummy_id",
+        client_secret: "dummy_secret",
+        api_url: "https://api.creatubbles.com/v2"
+      }
+    end
+
+    def self.dummy
+      new(dummy_auth_details)
+    end
+
+    Creatubbles::BaseCollection.define_type_name('test_objects')
+
+    def test_objects
+      Creatubbles::BaseCollection.new(connection)
+    end
+  end
+end