fix: Changes in NATS interceptor for error handling (#1103)

* fix: changes in nats intercepor for error handling

Signed-off-by: pranalidhanavade <[email protected]>

* fix: Error handling for send proof request with identical attributes when one attribute uses predicates and the other does not

Signed-off-by: pranalidhanavade <[email protected]>

* fix: Resolve comments on PR

Signed-off-by: pranalidhanavade <[email protected]>

* fix: added comments in service

Signed-off-by: pranalidhanavade <[email protected]>

* fix: added comments in service

Signed-off-by: pranalidhanavade <[email protected]>

---------

Signed-off-by: pranalidhanavade <[email protected]>

Author: pranalidhanavade

apps/verification/src/verification.service.ts

@@ -310,10 +310,26 @@ export class VerificationService {
         return getProofPresentationById?.response;
       }
     } catch (error) {
+      // Handle cases where identical attributes are used in both predicates and non-predicates.   
+      // This case is not supported in credo-ts, so we are handling in platform
+      // TODO: Handle all credo-errors globally in platform
+
+    const errorMessage = error?.status?.message?.error?.message; 
+    const match = errorMessage?.match(
+      /CredoError: The proof request contains duplicate predicates and attributes: (.+)/
+    );
+    if (match) {
+      const [, duplicateAttributes] = match;
+      throw new RpcException({
+        message: `CredoError: The proof request contains duplicate attributes: ${duplicateAttributes}`,
+        statusCode: 500
+      });
+    }
+
       this.logger.error(`[sendProofRequest] - error in sending proof request: ${JSON.stringify(error)}`);
       this.verificationErrorHandling(error);
+      }
     }
-  }
 
 
   /**

libs/interceptors/nats.interceptor.ts

@@ -17,11 +17,14 @@ import {
     intercept(context: ExecutionContext, next: CallHandler): Observable<unknown> {
       return next.handle().pipe(
         catchError((error) => {
-          if (error.message.includes(ResponseMessages.nats.error.natsConnect)) {
+          
+          if ('string' === typeof error.message && error.message.includes(ResponseMessages.nats.error.natsConnect)) {
             this.logger.error(`No subscribers for message: ${error.message}`);
             return throwError(() => new HttpException(ResponseMessages.nats.error.noSubscribers, 500));
+          } else if (error.message.message) {
+            return throwError(() => new HttpException(error.message.message, error.statusCode));
           }
-          return throwError(() => error);
+        return throwError(() => error);
         })
       );
     }