fix: comments on pull request

Signed-off-by: pranalidhanavade <[email protected]>

Author: pranalidhanavade

.env.demo

@@ -126,7 +126,7 @@ AFJ_AGENT_ENDPOINT_PATH=/agent-provisioning/AFJ/endpoints/
 
 AGENT_PROTOCOL=http
 OOB_BATCH_SIZE=10
-MAX_CONNECTIONS_LIMIT=10
+PROOF_REQ_CONN_LIMIT=10
 MAX_ORG_LIMIT=10
 FIDO_API_ENDPOINT=http://localhost:8000
 

.env.sample

@@ -98,7 +98,7 @@ PLATFORM_ID=
 PLATFORM_PROFILE_MODE= // Please provide your environment name
 
 OOB_BATCH_SIZE=10
-MAX_CONNECTIONS_LIMIT=10
+PROOF_REQ_CONN_LIMIT=10
 
 AFJ_AGENT_ENDPOINT_PATH=/apps/agent-provisioning/AFJ/endpoints/
 DATABASE_URL="postgresql://postgres:xxxxxx@localhost:5432/postgres?schema=public"    #Provide supabase postgres URL and Use the correct user/pwd, IP Address

apps/api-gateway/src/main.ts

@@ -2,7 +2,7 @@ import * as dotenv from 'dotenv';
 import * as express from 'express';
 
 import { DocumentBuilder, SwaggerModule } from '@nestjs/swagger';
-import { Logger, ValidationPipe, VersioningType } from '@nestjs/common';
+import { Logger, ValidationPipe, VERSION_NEUTRAL, VersioningType } from '@nestjs/common';
 
 import { AppModule } from './app.module';
 import { HttpAdapterHost, NestFactory } from '@nestjs/core';
@@ -58,7 +58,8 @@ async function bootstrap(): Promise<void> {
     .build();
 
     app.enableVersioning({
-      type: VersioningType.URI
+      type: VersioningType.URI,
+      defaultVersion: ['1']
     });
 
   const document = SwaggerModule.createDocument(app, options);
@@ -74,6 +75,11 @@ async function bootstrap(): Promise<void> {
     });
   }
 
+  app.enableVersioning({
+    type: VersioningType.URI,
+    defaultVersion: ['1', VERSION_NEUTRAL]
+  });
+
   app.use(express.static('uploadedFiles/holder-profile'));
   app.use(express.static('uploadedFiles/org-logo'));
   app.use(express.static('uploadedFiles/tenant-logo'));

apps/api-gateway/src/verification/dto/request-proof.dto.ts

@@ -290,7 +290,7 @@ export class ProofRequestPayloadDto extends RequestProofDtoBase {
   @IsNotEmpty({ each: true, message: 'connectionId array elements must not be empty' })
   @IsArray({ message: 'connectionId must be an array' })
   @ArrayMinSize(1, { message: 'connectionId must contain at least 1 element' })
-  @ArrayMaxSize(Number(process.env.MAX_CONNECTIONS_LIMIT), { message: `Limit reached (${process.env.MAX_CONNECTIONS_LIMIT} connections max).` })
+  @ArrayMaxSize(Number(process.env.PROOF_REQ_CONN_LIMIT), { message: `Limit reached (${process.env.PROOF_REQ_CONN_LIMIT} connections max).` })
   @IsUUID('all', { each: true, message: 'Each connectionId must be a valid UUID' })
   connectionId: string[];
 }

apps/api-gateway/src/verification/verification.controller.ts

@@ -12,7 +12,7 @@ import {
     ApiQuery,
     ApiExcludeEndpoint
 } from '@nestjs/swagger';
-import { Controller, Logger, Post, Body, Get, Query, HttpStatus, Res, UseGuards, Param, UseFilters, BadRequestException, ParseUUIDPipe, Delete, Version, VERSION_NEUTRAL } from '@nestjs/common';
+import { Controller, Logger, Post, Body, Get, Query, HttpStatus, Res, UseGuards, Param, UseFilters, BadRequestException, ParseUUIDPipe, Delete, Version } from '@nestjs/common';
 import { ApiResponseDto } from '../dtos/apiResponse.dto';
 import { UnauthorizedErrorDto } from '../dtos/unauthorized-error.dto';
 import { ForbiddenErrorDto } from '../dtos/forbidden-error.dto';
@@ -163,7 +163,6 @@ export class VerificationController {
      * @param orgId
      * @returns Requested proof presentation details
      */
-    @Version(VERSION_NEUTRAL)
     @Post('/orgs/:orgId/proofs')
     @ApiOperation({
         summary: `Sends a proof request`,
@@ -225,11 +224,11 @@ export class VerificationController {
      * @param orgId
      * @returns Requested proof presentation details
      */
-    @Version('1')
+    @Version('2')
     @Post('/orgs/:orgId/proofs')
     @ApiOperation({
         summary: `Sends a proof request`,
-        description: `Sends a proof request`
+        description: `Send a proof request on multiple connections`
     })
     @ApiResponse({ status: HttpStatus.OK, description: 'Success', type: ApiResponseDto })
     @ApiUnauthorizedResponse({ status: HttpStatus.UNAUTHORIZED, description: 'Unauthorized', type: UnauthorizedErrorDto })