refactor: update oid4vc flows (#1471)

* refactor: update oid4vc flows

Signed-off-by: Tipu_Singh <[email protected]>

* refactor: removed commented code

Signed-off-by: Tipu_Singh <[email protected]>

* refactor: changed example

Signed-off-by: Tipu_Singh <[email protected]>

---------

Signed-off-by: Tipu_Singh <[email protected]>

Author: tipusinghaw

apps/api-gateway/src/oid4vc-issuance/dtos/oid4vc-issuer-template.dto.ts

@@ -79,21 +79,21 @@ export class AppearanceDto {
   @ApiPropertyOptional({
     example: [
       {
-        locale: 'en',
-        name: 'Birth Certificate',
-        description: 'Official record of birth',
+        locale: 'de',
+        name: 'Geburtsurkunde',
+        description: 'Offizielle Geburtsbescheinigung',
         logo: {
           uri: 'https://upload.wikimedia.org/wikipedia/commons/2/2f/ABC-2021-LOGO.svg',
           alt_text: 'abc_logo'
         }
       },
       {
-        locale: 'ar',
-        name: 'شهادة الميلاد',
-        description: 'سجل رسمي للولادة',
+        locale: 'en',
+        name: 'Birth Certificate',
+        description: 'Official record of birth',
         logo: {
           uri: 'https://upload.wikimedia.org/wikipedia/commons/2/2f/ABC-2021-LOGO.svg',
-          alt_text: 'شعار abc'
+          alt_text: 'abc_logo'
         }
       }
     ]
@@ -146,7 +146,7 @@ export class CreateCredentialTemplateDto {
   @ApiPropertyOptional({
     description:
       'Verifiable Credential Type (required when format is "vc+sd-jwt"; must NOT be provided when format is "mso_mdoc")',
-    example: 'org.iso.18013.5.1.mDL'
+    example: 'BirthCertificateCredential-sdjwt'
   })
   @ValidateIf((o: CreateCredentialTemplateDto) => 'vc+sd-jwt' === o.format)
   @IsString()

apps/api-gateway/src/oid4vc-issuance/oid4vc-issuance.controller.ts

@@ -135,8 +135,8 @@ export class Oid4vcIssuanceController {
     return res.status(HttpStatus.CREATED).json(finalResponse);
   }
 
-  @Get('/orgs/:orgId/oid4vc/issuers/:issuerId')
-  @ApiOperation({ summary: 'Get OID4VC issuer', description: 'Retrieves an OID4VC issuer by issuerId.' })
+  @Get('/orgs/:orgId/oid4vc/issuers/:id')
+  @ApiOperation({ summary: 'Get OID4VC issuer', description: 'Retrieves an OID4VC issuer by id.' })
   @ApiResponse({ status: HttpStatus.OK, description: 'Issuer fetched successfully.', type: ApiResponseDto })
   @ApiBearerAuth()
   @Roles(OrgRoles.OWNER)
@@ -151,17 +151,17 @@ export class Oid4vcIssuanceController {
       })
     )
     orgId: string,
-    @Param('issuerId')
-    issuerId: string,
+    @Param('id')
+    id: string,
     @Res() res: Response
   ): Promise<Response> {
-    const oidcIssuer = await this.oid4vcIssuanceService.oidcGetIssuerById(issuerId, orgId);
+    const oidcIssuer = await this.oid4vcIssuanceService.oidcGetIssuerById(id, orgId);
     const finalResponse: IResponse = {
-      statusCode: HttpStatus.CREATED,
+      statusCode: HttpStatus.OK,
       message: ResponseMessages.oidcIssuer.success.fetch,
       data: oidcIssuer
     };
-    return res.status(HttpStatus.CREATED).json(finalResponse);
+    return res.status(HttpStatus.OK).json(finalResponse);
   }
 
   @Get('/orgs/:orgId/oid4vc/issuers')
@@ -194,7 +194,7 @@ export class Oid4vcIssuanceController {
     return res.status(HttpStatus.OK).json(finalResponse);
   }
 
-  @Delete('/orgs/:orgId/oid4vc/:issuerId')
+  @Delete('/orgs/:orgId/oid4vc/:id')
   @ApiOperation({
     summary: 'Delete OID4VC issuer',
     description: 'Deletes an OID4VC issuer for the specified organization.'
@@ -213,18 +213,18 @@ export class Oid4vcIssuanceController {
     )
     orgId: string,
     @Param(
-      'issuerId',
+      'id',
       new ParseUUIDPipe({
         exceptionFactory: (): Error => {
           throw new BadRequestException(ResponseMessages.organisation.error.invalidOrgId);
         }
       })
     )
-    issuerId: string,
+    id: string,
     @User() user: user,
     @Res() res: Response
   ): Promise<Response> {
-    await this.oid4vcIssuanceService.oidcDeleteIssuer(user, orgId, issuerId);
+    await this.oid4vcIssuanceService.oidcDeleteIssuer(user, orgId, id);
 
     const finalResponse: IResponse = {
       statusCode: HttpStatus.OK,
@@ -253,7 +253,6 @@ export class Oid4vcIssuanceController {
     @Res() res: Response
   ): Promise<Response> {
     CredentialTemplate.issuerId = issuerId;
-    console.log('THis is dto', JSON.stringify(CredentialTemplate, null, 2));
     const template = await this.oid4vcIssuanceService.createTemplate(CredentialTemplate, user, orgId, issuerId);
 
     const finalResponse: IResponse = {

apps/api-gateway/src/oid4vc-issuance/oid4vc-issuance.service.ts

@@ -37,8 +37,8 @@ export class Oid4vcIssuanceService extends BaseService {
     return this.natsClient.sendNatsMessage(this.issuanceProxy, 'oid4vc-issuer-update', payload);
   }
 
-  async oidcGetIssuerById(issuerId: string, orgId: string): Promise<object> {
-    const payload = { issuerId, orgId };
+  async oidcGetIssuerById(id: string, orgId: string): Promise<object> {
+    const payload = { id, orgId };
     return this.natsClient.sendNatsMessage(this.issuanceProxy, 'oid4vc-issuer-get-by-id', payload);
   }
 
@@ -47,8 +47,8 @@ export class Oid4vcIssuanceService extends BaseService {
     return this.natsClient.sendNatsMessage(this.issuanceProxy, 'oid4vc-get-issuers-issuance', payload);
   }
 
-  async oidcDeleteIssuer(userDetails: user, orgId: string, issuerId: string): Promise<object> {
-    const payload = { issuerId, orgId, userDetails };
+  async oidcDeleteIssuer(userDetails: user, orgId: string, id: string): Promise<object> {
+    const payload = { id, orgId, userDetails };
     return this.natsClient.sendNatsMessage(this.issuanceProxy, 'oid4vc-delete-issuer', payload);
   }