fix: Parameter validations (#1138)

* fix: added api param validations

Signed-off-by: bhavanakarwade <[email protected]>

* fix: removed unnecessary validations

Signed-off-by: bhavanakarwade <[email protected]>

* fix:resolved validations issue

Signed-off-by: bhavanakarwade <[email protected]>

* added comment on function for understanding

Signed-off-by: bhavanakarwade <[email protected]>

* fix: resolve orgid validations

Signed-off-by: bhavanakarwade <[email protected]>

* fix: added response message

Signed-off-by: bhavanakarwade <[email protected]>

* fix: added space in response messages

Signed-off-by: bhavanakarwade <[email protected]>

---------

Signed-off-by: bhavanakarwade <[email protected]>
Signed-off-by: Sahil Kamble <[email protected]>

Author: bhavanakarwade

apps/api-gateway/src/credential-definition/dto/create-cred-defs.dto.ts

@@ -1,18 +1,20 @@
 import { IsBoolean, IsDefined, IsNotEmpty, IsOptional, IsString } from 'class-validator';
-
 import { ApiProperty } from '@nestjs/swagger';
+import { Transform } from 'class-transformer';
+import { trim } from '@credebl/common/cast.helper';
 
 export class CreateCredentialDefinitionDto {
 
     @ApiProperty({ 'example': 'default' })
-    @IsDefined({ message: 'Tag is required.' })
+    @IsDefined({ message: 'Tag is required' })
     @IsNotEmpty({ message: 'Please provide a tag' })
-    @IsString({ message: 'Tag id should be string' })
+    @IsString({ message: 'Tag should be string' })
     tag: string;
 
     @ApiProperty({ 'example': 'WgWxqztrNooG92RXvxSTWv:2:schema_name:1.0' })
-    @IsDefined({ message: 'schemaLedgerId is required.' })
-    @IsNotEmpty({ message: 'Please provide a schema id' })
+    @IsDefined({ message: 'schemaLedgerId is required' })
+    @IsNotEmpty({ message: 'Please provide valid schema ledger Id' })
+    @Transform(({ value }) => trim(value))
     @IsString({ message: 'Schema id should be string' })
     schemaLedgerId: string;
 

apps/api-gateway/src/issuance/dtos/issuance.dto.ts

@@ -14,6 +14,7 @@ import {
   IsOptional,
   IsString,
   IsUrl,
+  IsUUID,
   MaxLength,
   ValidateNested
 } from 'class-validator';
@@ -647,6 +648,7 @@ export class FileQuery {
   @ApiProperty({ required: true })
   @IsString({ message: 'fileId should be string' })
   @IsNotEmpty({ message: 'fileId Id is required' })
+  @IsUUID('4', { message: 'Invalid format for file Id' })
   @Transform(({ value }) => trim(value))
   fileId: string;
 }

apps/api-gateway/src/issuance/issuance.controller.ts

@@ -73,6 +73,7 @@ import { IGetAllIssuedCredentialsDto } from './dtos/get-all-issued-credentials.d
 import { IssueCredentialDto } from './dtos/multi-connection.dto';
 import { SchemaType } from '@credebl/enum/enum';
 import { CommonConstants } from '../../../../libs/common/src/common.constant';
+import { TrimStringParamPipe } from '@credebl/common/cast.helper';
 @Controller()
 @UseFilters(CustomExceptionFilter)
 @ApiTags('credentials')
@@ -169,7 +170,7 @@ export class IssuanceController {
   @Roles(OrgRoles.OWNER, OrgRoles.ADMIN, OrgRoles.ISSUER, OrgRoles.VERIFIER, OrgRoles.MEMBER, OrgRoles.HOLDER)
   async getIssueCredentialsbyCredentialRecordId(
     @User() user: IUserRequest,
-    @Param('credentialRecordId') credentialRecordId: string,
+    @Param('credentialRecordId', TrimStringParamPipe, new ParseUUIDPipe({exceptionFactory: (): Error => { throw new BadRequestException(ResponseMessages.issuance.error.invalidCredentialRecordId); }})) credentialRecordId: string,
     @Param('orgId') orgId: string,
     @Res() res: Response
   ): Promise<Response> {

apps/api-gateway/src/organization/organization.controller.ts

@@ -108,7 +108,7 @@ export class OrganizationController {
     description: 'Retrieve the roles details for a specific organization.'
   })
   @ApiResponse({ status: HttpStatus.OK, description: 'Success', type: ApiResponseDto })
-  @UseGuards(AuthGuard('jwt'))
+  @UseGuards(AuthGuard('jwt'), OrgRolesGuard)
   @Roles(OrgRoles.OWNER, OrgRoles.ADMIN)
   @ApiBearerAuth()
   async getOrgRoles(

apps/issuance/src/issuance.service.ts

@@ -591,7 +591,7 @@ export class IssuanceService {
       this.logger.error(`[getIssueCredentialsbyCredentialRecordId] - error in get credentials : ${JSON.stringify(error)}`);
       if (error && error?.status && error?.status?.message && error?.status?.message?.error) {
         throw new RpcException({
-          message: error?.status?.message?.error?.reason ? error?.status?.message?.error?.reason : error?.status?.message?.error,
+          message: error?.status?.message?.error?.reason || error?.status?.message?.error?.message || error?.status?.message?.error,
           statusCode: error?.status?.code
         });
 

libs/common/src/response-messages/index.ts

@@ -307,6 +307,7 @@ export const ResponseMessages = {
       fileDetailsAndFileData:'File details and File data fetched successfully'
     },
     error: {
+      invalidCredentialRecordId: 'Please provide valid credential Record Id',
       exists: 'Credentials is already exist',
       credentialsNotFound: 'Credentials not found',
       agentEndPointNotFound: 'Agent details not found',