removed commented code and refactored

Signed-off-by: Rinkal Bhojani <[email protected]>

Author: RinkalBhojani

apps/api-gateway/src/oid4vc-issuance/dtos/oid4vc-issuer-template.dto.ts

@@ -29,33 +29,6 @@ class CredentialAttributeDisplayDto {
   locale?: string;
 }
 
-// export class CredentialAttributeDto {
-//   @ApiProperty({ required: false, description: 'Whether the attribute is mandatory' })
-//   @IsOptional()
-//   @IsBoolean()
-//   mandatory?: boolean;
-
-//   // TODO: Check how do we handle claims with only path rpoperty like email, etc.
-//   @ApiProperty({ description: 'Type of the attribute value (string, number, date, etc.)' })
-//   @IsString()
-//   value_type: string;
-
-//   @ApiProperty({
-//     type: [String],
-//     description:
-//       'Claims path pointer as per the draft 15 - https://openid.net/specs/openid-4-verifiable-credential-issuance-1_0-ID2.html#name-claims-path-pointer'
-//   })
-//   @IsArray()
-//   @IsString({ each: true })
-//   path: string[];
-
-//   @ApiProperty({ type: [CredentialAttributeDisplayDto], required: false, description: 'Localized display values' })
-//   @IsOptional()
-//   @ValidateNested({ each: true })
-//   @Type(() => CredentialAttributeDisplayDto)
-//   display?: CredentialAttributeDisplayDto[];
-// }
-
 export enum AttributeType {
   STRING = 'string',
   NUMBER = 'number',

apps/api-gateway/src/oid4vc-issuance/dtos/oid4vc-issuer.dto.ts

@@ -43,102 +43,6 @@ export class IssuerDisplayDto {
   logo?: LogoDto;
 }
 
-// TODO: Check where it is used, coz no reference found
-// @ApiExtraModels(ClaimDto)
-// export class CredentialConfigurationDto {
-//   @ApiProperty({
-//     description: 'The format of the credential',
-//     example: 'jwt_vc_json'
-//   })
-//   @IsString()
-//   @IsDefined({ message: 'format field is required' })
-//   @IsNotEmpty({ message: 'format property is required' })
-//   format: string;
-
-//   @ApiProperty({ required: false })
-//   @IsOptional()
-//   @IsString()
-//   vct?: string;
-
-//   @ApiProperty({ required: false })
-//   @IsOptional()
-//   @IsString()
-//   doctype?: string;
-
-//   @ApiProperty()
-//   @IsString()
-//   scope: string;
-
-//   @ApiProperty({
-//     description: 'List of claims supported in this credential',
-//     type: [ClaimDto]
-//   })
-//   @IsArray()
-//   @ValidateNested({ each: true })
-//   @Type(() => ClaimDto)
-//   claims: ClaimDto[];
-//   // @ApiProperty({
-//   //   description: 'Claims supported by this credential',
-//   //   type: 'object',
-//   //   additionalProperties: { $ref: getSchemaPath(ClaimDto) }
-//   // })
-//   // @IsObject()
-//   // @ValidateNested({ each: true })
-//   // @Transform(({ value }) =>
-//   //   Object.fromEntries(Object.entries(value || {}).map(([k, v]) => [k, plainToInstance(ClaimDto, v)]))
-//   // )
-//   // claims: Record<string, ClaimDto>;
-
-//   @ApiProperty({ type: [String] })
-//   @IsArray()
-//   credential_signing_alg_values_supported: string[];
-
-//   @ApiProperty({ type: [String] })
-//   @IsArray()
-//   cryptographic_binding_methods_supported: string[];
-
-//   @ApiProperty({
-//     description: 'Localized display information for the credential',
-//     type: [DisplayDto]
-//   })
-//   @IsArray()
-//   @ValidateNested({ each: true })
-//   @Type(() => DisplayDto)
-//   display: DisplayDto[];
-// }
-
-// export class AuthorizationServerConfigDto {
-//   @ApiProperty({
-//     description: 'Authorization server issuer URL',
-//     example: 'https://auth.credebl.com',
-//   })
-//   @IsUrl()
-//   issuer: string
-
-//   @ApiPropertyOptional({
-//     description: 'Token endpoint of the authorization server',
-//     example: 'https://auth.credebl.com/oauth/token',
-//   })
-//   @IsOptional()
-//   @IsUrl()
-//   token_endpoint: string
-
-//   @ApiProperty({
-//     description: 'Authorization endpoint of the server',
-//     example: 'https://auth.credebl.com/oauth/authorize',
-//   })
-//   @IsUrl()
-//   authorization_endpoint: string
-
-//   @ApiProperty({
-//     description: 'Supported scopes',
-//     example: ['openid', 'profile', 'email'],
-//   })
-//   @IsArray()
-//   @IsString({ each: true })
-//   scopes_supported: string[]
-// }
-
 export class ClientAuthenticationDto {
   @ApiProperty({
     description: 'OAuth2 client ID for the authorization server',

apps/oid4vc-issuance/interfaces/oid4vc-issuer-sessions.interfaces.ts

@@ -34,11 +34,8 @@ export interface CredentialPayload {
 }
 
 export interface CredentialRequest {
-  // credentialSupportedId?: string;
   templateId: string;
-  // format: CredentialFormat; // "vc+sd-jwt" | "mso_mdoc"
-  payload: CredentialPayload; // user-supplied payload (without vct)
-  // disclosureFrame?: DisclosureFrame; // only relevant for vc+sd-jwt
+  payload: CredentialPayload;
   validityInfo?: {
     validFrom: Date;
     validUntil: Date;
@@ -47,7 +44,6 @@ export interface CredentialRequest {
 
 export interface CreateOidcCredentialOffer {
   // e.g. "abc-gov"
-  // signerMethod: SignerMethodOption;      // only option selector
   authenticationType: AuthenticationType; // only option selector
   credentials: CredentialRequest[]; // one or more credentials
 }

apps/oid4vc-issuance/interfaces/oid4vc-template.interfaces.ts

@@ -1,12 +1,5 @@
 import { Prisma, SignerOption } from '@prisma/client';
 import { CredentialFormat } from '@credebl/enum/enum';
-
-// export interface CredentialAttribute {
-//   mandatory?: boolean;
-//   value_type: string;
-//   display?: Display[];
-// }
-
 export interface SdJwtTemplate {
   vct: string;
   attributes: CredentialAttribute[];
@@ -23,15 +16,11 @@ export interface MdocTemplate {
 export interface CreateCredentialTemplate {
   name: string;
   description?: string;
-  signerOption?: SignerOption; //SignerOption;
+  signerOption?: SignerOption;
   format: CredentialFormat;
   canBeRevoked: boolean;
-  // attributes: Prisma.JsonValue;
   appearance?: Prisma.JsonValue;
   issuerId: string;
-  // vct?: string;
-  // doctype?: string;
-
   template: SdJwtTemplate | MdocTemplate;
 }