fix: fixed coderabbitai suggestions and PR comments

Signed-off-by: Rinkal Bhojani <[email protected]>

Author: RinkalBhojani

Dockerfiles/Dockerfile.oid4vc-issuance

@@ -9,7 +9,6 @@ WORKDIR /app
 # Copy package.json and package-lock.json
 COPY package.json ./
 COPY pnpm-workspace.yaml ./
-#COPY package-lock.json ./
 
 ENV PUPPETEER_SKIP_DOWNLOAD=true
 
@@ -18,7 +17,6 @@ RUN pnpm i --ignore-scripts
 
 # Copy the rest of the application code
 COPY . .
-# RUN cd libs/prisma-service && npx prisma migrate deploy && npx prisma generate
 RUN cd libs/prisma-service && npx prisma generate
 
 # Build the oid4vc-issuance service
@@ -29,7 +27,7 @@ RUN npm run build oid4vc-issuance
 FROM node:18-alpine
 # Install OpenSSL
 RUN apk add --no-cache openssl
-# RUN npm install -g pnpm
+
 # Set the working directory
 WORKDIR /app
 
@@ -38,7 +36,7 @@ COPY --from=build /app/dist/apps/oid4vc-issuance/ ./dist/apps/oid4vc-issuance/
 
 # Copy the libs folder from the build stage
 COPY --from=build /app/libs/ ./libs/
-#COPY --from=build /app/package.json ./  
+
 COPY --from=build /app/node_modules  ./node_modules
 
 # Set the command to run the microservice

Dockerfiles/Dockerfile.oid4vc-verification

@@ -9,7 +9,6 @@ WORKDIR /app
 # Copy package.json and package-lock.json
 COPY package.json ./
 COPY pnpm-workspace.yaml ./
-#COPY package-lock.json ./
 
 ENV PUPPETEER_SKIP_DOWNLOAD=true
 
@@ -18,7 +17,7 @@ RUN pnpm i --ignore-scripts
 
 # Copy the rest of the application code
 COPY . .
-# RUN cd libs/prisma-service && npx prisma migrate deploy && npx prisma generate
+
 RUN cd libs/prisma-service && npx prisma generate
 
 # Build the oid4vc-verification service
@@ -29,7 +28,7 @@ RUN npm run build oid4vc-verification
 FROM node:18-alpine
 # Install OpenSSL
 RUN apk add --no-cache openssl
-# RUN npm install -g pnpm
+
 # Set the working directory
 WORKDIR /app
 
@@ -38,7 +37,7 @@ COPY --from=build /app/dist/apps/oid4vc-verification/ ./dist/apps/oid4vc-verific
 
 # Copy the libs folder from the build stage
 COPY --from=build /app/libs/ ./libs/
-#COPY --from=build /app/package.json ./  
+
 COPY --from=build /app/node_modules  ./node_modules
 
 # Set the command to run the microservice

apps/agent-service/src/agent-service.controller.ts

@@ -372,7 +372,7 @@ export class AgentServiceController {
 
   @MessagePattern({ cmd: 'agent-service-oid4vc-get-credential-offer-by-id' })
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  async oidcGetCredentialOfferById(payload: { url: string; orgId: string; offerId: string }): Promise<any> {
+  async oidcGetCredentialOfferById(payload: { url: string; orgId: string }): Promise<any> {
     return this.agentServiceService.oidcGetCredentialOfferById(payload.url, payload.orgId);
   }
 

apps/agent-service/src/agent-service.service.ts

@@ -2201,7 +2201,12 @@ export class AgentServiceService {
 
   private async tokenEncryption(token: string): Promise<string> {
     try {
-      const encryptedToken = CryptoJS.AES.encrypt(JSON.stringify(token), process.env.CRYPTO_PRIVATE_KEY).toString();
+      const secret = process.env.CRYPTO_PRIVATE_KEY;
+      if (!secret) {
+        this.logger.error('CRYPTO_PRIVATE_KEY is not configured');
+        throw new InternalServerErrorException('Encryption key is not configured');
+      }
+      const encryptedToken = CryptoJS.AES.encrypt(JSON.stringify(token), secret).toString();
 
       return encryptedToken;
     } catch (error) {
@@ -2312,6 +2317,7 @@ export class AgentServiceService {
       this.logger.error(
         `[getOid4vpVerifierSession] Error in getting oid4vp verifier session in agent service : ${JSON.stringify(error)}`
       );
+      throw error;
     }
   }
 

apps/api-gateway/src/agent-service/dto/create-schema.dto.ts

@@ -25,6 +25,7 @@ export class CreateTenantSchemaDto {
   attributes: string[];
 
   @ApiProperty()
+  @IsString({ message: 'orgId must be a string' })
   @IsNotEmpty({ message: 'please provide orgId' })
   orgId: string;
 }

apps/api-gateway/src/connection/connection.service.ts

@@ -44,7 +44,7 @@ export class ConnectionService extends BaseService {
         basicMessageDto
       );
     } catch (error) {
-      throw new RpcException(error.response);
+      throw new RpcException(error?.response ?? error);
     }
   }
 
@@ -60,7 +60,7 @@ export class ConnectionService extends BaseService {
       const connectionDetails = { referenceId };
       return this.natsClient.sendNats(this.connectionServiceProxy, 'get-connection-url', connectionDetails);
     } catch (error) {
-      throw new RpcException(error.response);
+      throw new RpcException(error?.response ?? error);
     }
   }