codecov, tests (#10)

Author: crenshaw-dev

.github/workflows/build.yaml

@@ -27,6 +27,14 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v3
+      - name: Set up go
+        uses: actions/setup-go@v2
+        with:
+          go-version: 1.19
+      - name: Test
+        run: make test
+      - name: Upload coverage to Codecov
+        uses: codecov/codecov-action@v3
       - name: Set up QEMU
         uses: docker/setup-qemu-action@v2
       - name: Set up Docker Buildx

.gitignore

@@ -1 +1,2 @@
 .idea
+cover.out

Makefile

@@ -26,3 +26,7 @@ submit:
 .PHONY: clean
 clean:
 	bash scripts/delete_cluster.sh
+
+.PHONY: test
+test:
+	go test -v ./... -coverprofile cover.out

internal/argocd_executor_test.go

@@ -0,0 +1,32 @@
+package argocd
+
+import (
+	"context"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func Test_durationStringToContext(t *testing.T) {
+	t.Parallel()
+
+	t.Run("empty", func(t *testing.T) {
+		ctx, cancel, err := durationStringToContext("")
+		require.NoError(t, err)
+		t.Cleanup(cancel)
+		assert.Equal(t, context.Background(), ctx)
+	})
+
+	t.Run("invalid", func(t *testing.T) {
+		_, _, err := durationStringToContext("invalid")
+		require.Error(t, err)
+	})
+
+	t.Run("valid", func(t *testing.T) {
+		ctx, cancel, err := durationStringToContext("1s")
+		require.NoError(t, err)
+		t.Cleanup(cancel)
+		assert.NotEqual(t, context.Background(), ctx)
+	})
+}

internal/plugin_test.go

@@ -43,18 +43,21 @@ func (errReader) Read(_ []byte) (n int, err error) {
 }
 
 type executorSpy struct {
-	Called bool
+	AuthorizeCalled bool
+	ExecuteCalled   bool
 }
 
-func (e *executorSpy) Execute(_ executor.ExecuteTemplateArgs) executor.ExecuteTemplateReply {
-	e.Called = true
+func (e *executorSpy) Authorize(_ *http.Request) error {
+	e.AuthorizeCalled = true
+	return nil
+}
 
+func (e *executorSpy) Execute(_ executor.ExecuteTemplateArgs) executor.ExecuteTemplateReply {
+	e.ExecuteCalled = true
 	return executor.ExecuteTemplateReply{}
 }
 
 func TestArgocdPlugin(t *testing.T) {
-	// test returning correct result based on input
-
 	spy := executorSpy{}
 	argocdPlugin := ArgocdPlugin(&spy)
 	handler := http.HandlerFunc(argocdPlugin)
@@ -112,41 +115,4 @@ func TestArgocdPlugin(t *testing.T) {
 			assert.Equal(t, gotStatus, tt.status)
 		})
 	}
-
-	var execTests = []struct {
-		name   string
-		fail   bool
-		status int
-	}{
-		{
-			name:   "exec without fail",
-			fail:   false,
-			status: http.StatusOK,
-		},
-		{
-			name:   "exec fails",
-			fail:   true,
-			status: http.StatusInternalServerError,
-		},
-	}
-
-	body := validWorkflowBody
-	for _, tt := range execTests {
-		t.Run(tt.name, func(t *testing.T) {
-			spy.Called = false
-			request, _ := http.NewRequest(http.MethodPost, "/api/v1/template.execute", bytes.NewReader(body))
-			request.Header.Set("Content-Type", "application/json")
-			response := httptest.NewRecorder()
-			handler.ServeHTTP(response, request)
-
-			if !spy.Called && !tt.fail {
-				t.Error("ApiExecutor was not called")
-			}
-
-			got := response.Result().StatusCode
-
-			assert.Equal(t, got, tt.status)
-			assert.Equal(t, got, tt.status)
-		})
-	}
 }