use different assert lib

Author: crenshaw-dev

go.mod

@@ -5,7 +5,7 @@ go 1.19
 require (
 	github.com/argoproj/argo-cd/v2 v2.5.0
 	github.com/argoproj/argo-workflows/v3 v3.3.5
-	github.com/magiconair/properties v1.8.5
+	github.com/stretchr/testify v1.7.1
 	k8s.io/utils v0.0.0-20220210201930-3a6ce19ff2f9
 )
 
@@ -96,7 +96,6 @@ require (
 	github.com/sirupsen/logrus v1.8.1 // indirect
 	github.com/spf13/cobra v1.5.0 // indirect
 	github.com/spf13/pflag v1.0.5 // indirect
-	github.com/stretchr/testify v1.7.1 // indirect
 	github.com/vmihailenco/go-tinylfu v0.2.1 // indirect
 	github.com/vmihailenco/msgpack/v5 v5.3.4 // indirect
 	github.com/vmihailenco/tagparser/v2 v2.0.0 // indirect

go.sum

@@ -549,7 +549,6 @@ github.com/lpabon/godbc v0.1.1/go.mod h1:Jo9QV0cf3U6jZABgiJ2skINAXb9j8m51r07g4KI
 github.com/lyft/protoc-gen-validate v0.0.13/go.mod h1:XbGvPuh87YZc5TdIa2/I4pLk0QoUACkjt2znoq26NVQ=
 github.com/magiconair/properties v1.8.0/go.mod h1:PppfXfuXeibc/6YijjN8zIbojt8czPbwD3XqdrwzmxQ=
 github.com/magiconair/properties v1.8.1/go.mod h1:PppfXfuXeibc/6YijjN8zIbojt8czPbwD3XqdrwzmxQ=
-github.com/magiconair/properties v1.8.5 h1:b6kJs+EmPFMYGkow9GiUyCyOvIwYetYJ3fSaWak/Gls=
 github.com/magiconair/properties v1.8.5/go.mod h1:y3VJvCyxH9uVvJTWEGAELF3aiYNyPKd5NZ3oSwXrF60=
 github.com/mailru/easyjson v0.0.0-20190614124828-94de47d64c63/go.mod h1:C1wdFJiN94OJF2b5HbByQZoLdCWB1Yqtg26g4irojpc=
 github.com/mailru/easyjson v0.0.0-20190626092158-b2ccc519800e/go.mod h1:C1wdFJiN94OJF2b5HbByQZoLdCWB1Yqtg26g4irojpc=

internal/plugin_test.go

@@ -10,15 +10,15 @@ import (
 	"testing"
 
 	"github.com/argoproj/argo-workflows/v3/pkg/plugins/executor"
-	"github.com/magiconair/properties/assert"
+	"github.com/stretchr/testify/assert"
 )
 
 var (
-	headerEmpty				 			= map[string]string{}
-	headerContentJson 			= map[string]string{"Content-Type": "application/json"}
-	headerContentEncoded		= map[string]string{"Content-Type": "application/x-www-form-urlencoded"}
-	validWorkflowBody 			= []byte(
-`{
+	headerEmpty          = map[string]string{}
+	headerContentJson    = map[string]string{"Content-Type": "application/json"}
+	headerContentEncoded = map[string]string{"Content-Type": "application/x-www-form-urlencoded"}
+	validWorkflowBody    = []byte(
+		`{
   "workflow": {
 	  "metadata": {
       "name": "test-template"
@@ -39,11 +39,11 @@ var (
 type errReader int
 
 func (errReader) Read(_ []byte) (n int, err error) {
-    return 0, errors.New("read error")
+	return 0, errors.New("read error")
 }
 
 type executorSpy struct {
-	Called 	bool
+	Called bool
 }
 
 func (e *executorSpy) Execute(_ executor.ExecuteTemplateArgs) executor.ExecuteTemplateReply {
@@ -55,16 +55,16 @@ func (e *executorSpy) Execute(_ executor.ExecuteTemplateArgs) executor.ExecuteTe
 func TestArgocdPlugin(t *testing.T) {
 	// test returning correct result based on input
 
-  	spy := executorSpy{}
+	spy := executorSpy{}
 	argocdPlugin := ArgocdPlugin(&spy)
 	handler := http.HandlerFunc(argocdPlugin)
 
 	var failTests = []struct {
-		name string
-		body io.Reader
+		name    string
+		body    io.Reader
 		headers map[string]string
-		want string
-		status int
+		want    string
+		status  int
 	}{
 		{
 			name:    "fail header content-type is empty",
@@ -104,7 +104,7 @@ func TestArgocdPlugin(t *testing.T) {
 			}
 			response := httptest.NewRecorder()
 			handler.ServeHTTP(response, request)
-			
+
 			got := strings.Trim(response.Body.String(), "\n")
 			gotStatus := response.Result().StatusCode
 
@@ -114,18 +114,18 @@ func TestArgocdPlugin(t *testing.T) {
 	}
 
 	var execTests = []struct {
-		name string
-		fail bool
+		name   string
+		fail   bool
 		status int
 	}{
 		{
-			name: "exec without fail",
-			fail: false,
+			name:   "exec without fail",
+			fail:   false,
 			status: http.StatusOK,
 		},
 		{
-			name: "exec fails",
-			fail: true,
+			name:   "exec fails",
+			fail:   true,
 			status: http.StatusInternalServerError,
 		},
 	}
@@ -138,7 +138,7 @@ func TestArgocdPlugin(t *testing.T) {
 			request.Header.Set("Content-Type", "application/json")
 			response := httptest.NewRecorder()
 			handler.ServeHTTP(response, request)
-			
+
 			if !spy.Called && !tt.fail {
 				t.Error("ApiExecutor was not called")
 			}
@@ -148,6 +148,5 @@ func TestArgocdPlugin(t *testing.T) {
 			assert.Equal(t, got, tt.status)
 			assert.Equal(t, got, tt.status)
 		})
-  }
+	}
 }
-