added some simple test, need to break ArgocdPlugin to smaller units that try to actually do stuff. ArgocdPlugin should only test if it can get values and pass it to interfaces and stuff.

Author: UrielCohen456

Makefile

@@ -1,10 +1,10 @@
 .DEFAULT_GOAL := apply
 
-# Local build
+.PHONY: build
 build:
 	@scripts/build_plugin.sh
 
-apply: build
+apply: 
 	@kubectl apply -n argo -f deployments/argocd-executor-plugin-configmap.yaml
 	@kubectl apply -n argo -f examples/rbac.yaml
 

README.md

@@ -20,7 +20,8 @@ spec:
           actions:
             - sync:
                 project: guestbook
-                app: guestbook
+                apps:
+                  - guestbook
 ```
 
 ## Getting Started

cmd/argocd-plugin/main.go

@@ -1,15 +1,26 @@
 package main
 
 import (
-	"context"
 	"net/http"
 
+	"k8s.io/client-go/kubernetes"
+	"k8s.io/client-go/rest"
+
 	"github.com/UrielCohen456/argo-workflows-argocd-executor-plugin/common"
 	argocd "github.com/UrielCohen456/argo-workflows-argocd-executor-plugin/internal/argocd-plugin"
 )
 
 func main() {
-	ctx := context.WithValue(context.Background(), "namespace", common.Namespace());
-	http.HandleFunc("/api/v1/template.execute",  argocd.ArgocdPlugin(ctx))
+	config, err := rest.InClusterConfig()
+	if err != nil {
+		panic(err.Error())
+	}
+
+	client, err := kubernetes.NewForConfig(config)
+	if err != nil {
+		panic(err.Error())
+	}
+
+	http.HandleFunc("/api/v1/template.execute",  argocd.ArgocdPlugin(client, common.Namespace()))
 	http.ListenAndServe(":4355", nil)
 }

common/common.go

@@ -4,6 +4,7 @@ import (
 	"io/ioutil"
 	"os"
 	"strings"
+	"testing"
 )
 
 // Returns the namespace the pod runs in.
@@ -22,3 +23,17 @@ func Namespace() string {
 
 	return "default"
 }
+
+func AssertResponseBody(t testing.TB, got, want string) {
+	t.Helper()
+	if got != want {
+		t.Errorf("response body is wrong, got %q want %q", got, want)
+	}
+}
+
+func AssertStatus(t testing.TB, got, want int) {
+	t.Helper()
+	if got != want {
+		t.Errorf("did not get correct status, got %d, want %d", got, want)
+	}
+}

deployments/README.md

@@ -2,7 +2,7 @@
 # argocd
 
 * Needs: >= v3.3
-* Image: urielc12/argocd-plugin:v0.1.0
+* Image: urielc12/argocd-plugin
 
 This is an ArgoCD plugin that allows you to interact with an argocd instance of your choice.
 For examples visit https://github.com/UrielCohen456/argo-workflows-argocd-executor-plugin/examples

deployments/argocd-executor-plugin-configmap.yaml

@@ -2,7 +2,7 @@
 apiVersion: v1
 data:
   sidecar.container: |
-    image: urielc12/argocd-plugin:v0.1.0
+    image: urielc12/argocd-plugin
     name: argocd-executor-plugin
     ports:
     - containerPort: 4355

deployments/plugin.yaml

@@ -11,7 +11,7 @@ spec:
   sidecar:
     container:
       name: argocd-executor-plugin
-      image: urielc12/argocd-plugin:v0.1.0
+      image: urielc12/argocd-plugin
       ports:
         - containerPort: 4355
       resources:

examples/argocd-example-wf.yaml

@@ -4,18 +4,18 @@ metadata:
   generateName: argocd-example-
 spec:
   ttlStrategy:
-    secondsAfterCompletion: 60
+    secondsAfterCompletion: 300
+    secondsAfterFailure: 300
+    secondsAfterSuccess: 300
   serviceAccountName: workflow
   entrypoint: main
   templates:
     - name: main
       plugin:
         argocd:
-          serverUrl: https://my-argocd-instance.com/
+          serverUrl: argocd-server.argocd.svc.cluster.local
           actions:
             - sync:
                 project: default
-                app: guestbook
-            - refresh:
-                project: default
-                app: guestbook
+                apps:
+                  - guestbook

go.mod

@@ -9,33 +9,47 @@ require (
 )
 
 require (
+	github.com/PuerkitoBio/purell v1.1.1 // indirect
+	github.com/PuerkitoBio/urlesc v0.0.0-20170810143723-de5bf2ad4578 // indirect
+	github.com/argoproj/argo-workflows/v3 v3.3.1 // indirect
 	github.com/davecgh/go-spew v1.1.1 // indirect
-	github.com/go-logr/logr v1.2.0 // indirect
+	github.com/emicklei/go-restful v2.15.0+incompatible // indirect
+	github.com/evanphx/json-patch v5.6.0+incompatible // indirect
+	github.com/go-logr/logr v1.2.2 // indirect
+	github.com/go-openapi/jsonpointer v0.19.5 // indirect
+	github.com/go-openapi/jsonreference v0.19.6 // indirect
+	github.com/go-openapi/swag v0.19.15 // indirect
 	github.com/gogo/protobuf v1.3.2 // indirect
 	github.com/golang/protobuf v1.5.2 // indirect
-	github.com/google/go-cmp v0.5.5 // indirect
-	github.com/google/gofuzz v1.1.0 // indirect
+	github.com/google/go-cmp v0.5.7 // indirect
+	github.com/google/gofuzz v1.2.0 // indirect
 	github.com/googleapis/gnostic v0.5.5 // indirect
+	github.com/grpc-ecosystem/grpc-gateway v1.16.0 // indirect
+	github.com/josharian/intern v1.0.0 // indirect
 	github.com/json-iterator/go v1.1.12 // indirect
+	github.com/mailru/easyjson v0.7.7 // indirect
 	github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
 	github.com/modern-go/reflect2 v1.0.2 // indirect
+	github.com/pkg/errors v0.9.1 // indirect
 	github.com/pmezard/go-difflib v1.0.0 // indirect
-	golang.org/x/net v0.0.0-20211209124913-491a49abca63 // indirect
-	golang.org/x/oauth2 v0.0.0-20210819190943-2bc19b11175f // indirect
-	golang.org/x/sys v0.0.0-20210831042530-f4d43177bf5e // indirect
-	golang.org/x/term v0.0.0-20210615171337-6886f2dfbf5b // indirect
+	golang.org/x/net v0.0.0-20220127200216-cd36cc0744dd // indirect
+	golang.org/x/oauth2 v0.0.0-20211104180415-d3ed0bb246c8 // indirect
+	golang.org/x/sys v0.0.0-20220209214540-3681064d5158 // indirect
+	golang.org/x/term v0.0.0-20210927222741-03fcf44c2211 // indirect
 	golang.org/x/text v0.3.7 // indirect
-	golang.org/x/time v0.0.0-20210723032227-1f47c861a9ac // indirect
+	golang.org/x/time v0.0.0-20220210224613-90d013bbcef8 // indirect
 	google.golang.org/appengine v1.6.7 // indirect
+	google.golang.org/genproto v0.0.0-20220218161850-94dd64e39d7c // indirect
+	google.golang.org/grpc v1.44.0 // indirect
 	google.golang.org/protobuf v1.27.1 // indirect
 	gopkg.in/inf.v0 v0.9.1 // indirect
 	gopkg.in/yaml.v2 v2.4.0 // indirect
 	gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b // indirect
 	k8s.io/api v0.23.5 // indirect
-	k8s.io/klog/v2 v2.30.0 // indirect
-	k8s.io/kube-openapi v0.0.0-20211115234752-e816edb12b65 // indirect
-	k8s.io/utils v0.0.0-20211116205334-6203023598ed // indirect
-	sigs.k8s.io/json v0.0.0-20211020170558-c049b76a60c6 // indirect
+	k8s.io/klog/v2 v2.40.1 // indirect
+	k8s.io/kube-openapi v0.0.0-20220124234850-424119656bbf // indirect
+	k8s.io/utils v0.0.0-20220210201930-3a6ce19ff2f9 // indirect
+	sigs.k8s.io/json v0.0.0-20211208200746-9f7c6b3444d2 // indirect
 	sigs.k8s.io/structured-merge-diff/v4 v4.2.1 // indirect
-	sigs.k8s.io/yaml v1.2.0 // indirect
+	sigs.k8s.io/yaml v1.3.0 // indirect
 )