Skip to content

Commit 49497e6

Browse files
fix: update okta test to expect ValueError instead of AssertionError
1 parent 8235c54 commit 49497e6

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

tests/cli/authentication/providers/test_okta.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
import pytest
2+
23
from crewai.cli.authentication.main import Oauth2Settings
34
from crewai.cli.authentication.providers.okta import OktaProvider
45

56

67
class TestOktaProvider:
7-
88
@pytest.fixture(autouse=True)
99
def setup_method(self):
1010
self.valid_settings = Oauth2Settings(
1111
provider="okta",
1212
domain="test-domain.okta.com",
1313
client_id="test-client-id",
14-
audience="test-audience"
14+
audience="test-audience",
1515
)
1616
self.provider = OktaProvider(self.valid_settings)
1717

@@ -32,7 +32,7 @@ def test_get_authorize_url_with_different_domain(self):
3232
provider="okta",
3333
domain="my-company.okta.com",
3434
client_id="test-client",
35-
audience="test-audience"
35+
audience="test-audience",
3636
)
3737
provider = OktaProvider(settings)
3838
expected_url = "https://my-company.okta.com/oauth2/default/v1/device/authorize"
@@ -47,7 +47,7 @@ def test_get_token_url_with_different_domain(self):
4747
provider="okta",
4848
domain="another-domain.okta.com",
4949
client_id="test-client",
50-
audience="test-audience"
50+
audience="test-audience",
5151
)
5252
provider = OktaProvider(settings)
5353
expected_url = "https://another-domain.okta.com/oauth2/default/v1/token"
@@ -62,7 +62,7 @@ def test_get_jwks_url_with_different_domain(self):
6262
provider="okta",
6363
domain="dev.okta.com",
6464
client_id="test-client",
65-
audience="test-audience"
65+
audience="test-audience",
6666
)
6767
provider = OktaProvider(settings)
6868
expected_url = "https://dev.okta.com/oauth2/default/v1/keys"
@@ -77,7 +77,7 @@ def test_get_issuer_with_different_domain(self):
7777
provider="okta",
7878
domain="prod.okta.com",
7979
client_id="test-client",
80-
audience="test-audience"
80+
audience="test-audience",
8181
)
8282
provider = OktaProvider(settings)
8383
expected_issuer = "https://prod.okta.com/oauth2/default"
@@ -91,11 +91,11 @@ def test_get_audience_assertion_error_when_none(self):
9191
provider="okta",
9292
domain="test-domain.okta.com",
9393
client_id="test-client-id",
94-
audience=None
94+
audience=None,
9595
)
9696
provider = OktaProvider(settings)
9797

98-
with pytest.raises(AssertionError):
98+
with pytest.raises(ValueError, match="Audience is required"):
9999
provider.get_audience()
100100

101101
def test_get_client_id(self):

0 commit comments

Comments
 (0)