Skip to content

Commit bed9a38

Browse files
fix: remove invalid param from sse client (#3980)
1 parent 5239dc9 commit bed9a38

File tree

2 files changed

+22
-1
lines changed

2 files changed

+22
-1
lines changed

lib/crewai/src/crewai/mcp/transports/sse.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ async def connect(self) -> Self:
6666
self._transport_context = sse_client(
6767
self.url,
6868
headers=self.headers if self.headers else None,
69-
terminate_on_close=True,
7069
)
7170

7271
read, write = await self._transport_context.__aenter__()
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
"""Tests for SSE transport."""
2+
3+
import pytest
4+
5+
from crewai.mcp.transports.sse import SSETransport
6+
7+
8+
@pytest.mark.asyncio
9+
async def test_sse_transport_connect_does_not_pass_invalid_args():
10+
"""Test that SSETransport.connect() doesn't pass invalid args to sse_client.
11+
12+
The sse_client function does not accept terminate_on_close parameter.
13+
"""
14+
transport = SSETransport(
15+
url="http://localhost:9999/sse",
16+
headers={"Authorization": "Bearer test"},
17+
)
18+
19+
with pytest.raises(ConnectionError) as exc_info:
20+
await transport.connect()
21+
22+
assert "unexpected keyword argument" not in str(exc_info.value)

0 commit comments

Comments
 (0)