Skip to content

Commit 52a960d

Browse files
committed
fix tests
1 parent a69c6a3 commit 52a960d

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

src/test/scala/gym/envs/EnvFactoryTest.scala

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package io.github.cric96
22
package gym.envs
33

4-
import gym.{ExternalType, Gym}
4+
import gym.ExternalType
55
import gym.ExternalType.NumpyArray
66
import gym.core.Env
77
import gym.envs.EnvFactory.{Box2D, ClassicControl, ToyText}
@@ -16,6 +16,7 @@ object EnvFactoryTest extends TestSuite {
1616

1717
@SuppressWarnings(Array("org.wartremover.warts.Nothing")) //because of test frame
1818
val tests = Tests {
19+
@SuppressWarnings(Array("org.wartremover.warts.Any", "org.wartremover.warts.DefaultArguments")) //because of CI
1920
def checkEnv[A, O, AS[a] <: Space[a], OS[o] <: Space[o]](
2021
env: Env[A, O, AS, OS],
2122
onCI: Boolean = true
@@ -26,18 +27,18 @@ object EnvFactoryTest extends TestSuite {
2627
spaceReader: Reader[AS[A]],
2728
obsReader: Reader[OS[O]]
2829
): Boolean = {
29-
val ci = System.getenv("CI")
30+
val ci = System.getenv().containsKey("CI")
3031
val result = for {
3132
initState <- Try(env.reset())
3233
observation <- Try(env.step(env.actionSpace.sample()).observation)
3334
} yield (initState, observation)
3435
env.close()
3536
result.recoverWith { case exc =>
3637
println(exc.getMessage)
37-
if (onCI) { Failure(exc) }
38+
if (onCI && ci) { Failure(exc) }
3839
else {
3940
println("Skip..")
40-
Try {}
41+
Try()
4142
}
4243
}.isSuccess
4344
}

0 commit comments

Comments
 (0)