fix lint

fmigneault · fmigneault · commit 466c6f614048 · 2026-02-19T21:40:28.000-05:00
diff --git a/.agents/skills/weaver-skills-update/SKILL.md b/.agents/skills/weaver-skills-update/SKILL.md
@@ -528,7 +528,8 @@ A script is provided to validate YAML frontmatter and cross-references in all sk
 **What it validates**:
 
 - **YAML frontmatter**: Ensures all skills have valid YAML frontmatter between `---` markers
-- **Cross-references**: Checks that all relative links to other skills (`../skill-name/`) point to existing skill directories
+- **Cross-references**: Checks that all relative links to other skills (`../skill-name/`)
+  point to existing skill directories
 
 **Example output**:
 
diff --git a/.agents/skills/weaver-skills-update/scripts/check-frontmatter.py b/.agents/skills/weaver-skills-update/scripts/check-frontmatter.py
@@ -5,6 +5,7 @@
 """
 import os
 import sys
+
 import yaml
 
 skills_dir = ".agents/skills"
@@ -16,7 +17,7 @@
     if not os.path.isfile(skill_path):
         continue
 
-    with open(skill_path, 'r') as f:
+    with open(skill_path, mode="r", encoding="utf-8") as f:
         content = f.read()
 
     parts = content.split('---')
diff --git a/.pylintrc b/.pylintrc
@@ -9,11 +9,27 @@ extension-pkg-whitelist=lxml.etree,
 
 # Add files or directories to the blacklist. They should be base names, not
 # paths.
-ignore=CVS
+ignore=
+    CVS,
+    env,
+    .venv,
+    .env,
+    .git,
+    .github,
+    .vscode,
+    .idea,
+    .run,
+    .tox,
+    .eggs,
+    build,
+    dist,
+    reports,
+    node_modules,
+
 
 # Add files or directories matching the regex patterns to the blacklist. The
 # regex matches against base names, not paths.
-ignore-patterns=
+ignore-patterns=.*\.egg-info,
 
 # Python code to execute, usually for sys.path manipulation such as
 # pygtk.require().
@@ -131,7 +147,8 @@ disable=C0111,missing-docstring,
 # note: (C0412, ungrouped-imports) is managed via isort tool, ignore false positives
 
 per-file-ignores =
-  tests/*:R1729
+    .agents/skills/*/scripts/*:C0103,
+    tests/*:R1729
 
 # Enable the message, report, category or checker with the given id(s). You can
 # either give multiple identifier separated by comma (,) or put this option
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -12,7 +12,7 @@ Changes
 
 Changes:
 --------
-- Set up `Weaver Agent Skills <./.agent/skills>`_ based on
+- Set up `Weaver Agent Skills <./.agents/skills>`_ based on
   the `Agent Skill Specification <https://agentskills.io/specification>`_
   to help AI agents interact with `Weaver` and its API more seamlessly.
 
diff --git a/Makefile b/Makefile
@@ -543,7 +543,8 @@ check-lint-only: | mkdir-reports  	## check linting of code style
 		pylint \
 			--rcfile="$(APP_ROOT)/.pylintrc" \
 			--reports y \
-			"$(APP_ROOT)/weaver" "$(APP_ROOT)/tests" \
+			"$(APP_ROOT)/" \
+			$(PYLINT_XARGS) \
 		1> >(tee "$(REPORTS_DIR)/check-lint.txt")'
 
 .PHONY: check-security-only
@@ -629,7 +630,11 @@ check-docstring-only: | mkdir-reports  ## check code docstring style and linting
 	@echo "Running docstring checks..."
 	@-rm -fr "$(REPORTS_DIR)/check-docstring.txt"
 	@bash -c '$(CONDA_CMD) \
-		pydocstyle --explain --config "$(APP_ROOT)/setup.cfg" "$(APP_ROOT)" \
+		pydocstyle \
+			--explain \
+			--config "$(APP_ROOT)/setup.cfg" \
+			--match-dir "^(node_submodules)" \
+			"$(APP_ROOT)" \
 		1> >(tee "$(REPORTS_DIR)/check-docstring.txt")'
 
 .PHONY: check-links-only
diff --git a/docs/_extensions/doc_redirect.py b/docs/_extensions/doc_redirect.py
@@ -107,7 +107,7 @@ def generate_redirects(app):
         # create unless it already exists (eg: same directory level, config map is redundant)
         if not os.path.exists(redirected_html_file):
             # if using a direct call with .html extension, it will still work as if calling the .rst
-            with open(redirected_html_file, "w") as f:
+            with open(redirected_html_file, mode="w", encoding="utf-8") as f:
                 f.write(TEMPLATE % to_path)
         if not os.path.exists(redirected_rst_file):
             # point to the .rst that would be reach by clicking the literal reference
diff --git a/docs/examples/vault_upload.py b/docs/examples/vault_upload.py
@@ -10,7 +10,7 @@
 files = {
     "file": (
         "desired-name.json",
-        open(PATH, "r", encoding="utf-8"),
+        open(PATH, mode="r", encoding="utf-8"),  # pylint: disable=R1732
         "application/json; charset=UTF-8"
     )
 }
diff --git a/docs/source/conf.py b/docs/source/conf.py
@@ -39,7 +39,7 @@
 sys.path.insert(0, os.path.abspath(DOC_PRJ_ROOT))
 
 from weaver import __meta__  # isort:skip # noqa: E402 # pylint: disable=C0413
-from weaver.wps_restapi.api import get_openapi_json  # isort:skip # noqa: E402
+from weaver.wps_restapi.api import get_openapi_json  # isort:skip # noqa: E402 # pylint: disable=C0413
 
 DOC_PKG_ROOT = os.path.join(DOC_PRJ_ROOT, __meta__.__name__)
 
@@ -109,7 +109,7 @@ def doc_redirect_include(file_path):
 )
 if not os.path.isdir(DOC_BLD_ROOT):
     os.makedirs(DOC_BLD_ROOT)
-with open(api_spec_file, "w") as f:
+with open(api_spec_file, mode="w", encoding="utf-8") as f:
     json.dump(api_spec_json, f, use_decimal=True)
 
 redoc = [{
diff --git a/setup.cfg b/setup.cfg
@@ -103,7 +103,7 @@ skip = *.egg*,build,env,src,venv,reports,node_modules
 
 [bandit]
 skips = B101,B320,B410
-exclude = *.egg-info,./build,./dist,./env,./tests,test_*
+exclude = *.egg-info,./build,./dist,./env,./node_modules,./tests,test_*
 targets = .
 
 [flake8]
@@ -134,6 +134,18 @@ wrap-descriptions = 0
 wrap-summaries = 120
 make-summary-multi-line = True
 pre-summary-newline = True
+exclude =
+    ./git,
+    ./github,
+    ./.idea,
+    ./.run,
+    ./.vscode,
+    ./build,
+    ./dist,
+    ./env,
+    ./.venv,
+    ./node_modules,
+    ./reports,
 
 [pydocstyle]
 add_ignore = D100,D101,D102,D103,D104,D105,D107,D200,D202,D204,D212,D401
diff --git a/setup.py b/setup.py
@@ -21,7 +21,7 @@
         DOC_REMOVE_PYPI_START = LONG_DESCRIPTION.find(".. remove-pypi-start")
         DOC_REMOVE_PYPI_END = LONG_DESCRIPTION.find(".. remove-pypi-end")
         if (
-            DOC_REMOVE_PYPI_START > 0 and  # noqa
+            DOC_REMOVE_PYPI_START > 0 and  # noqa  # pylint: disable=R1716
             DOC_REMOVE_PYPI_END > 0 and
             DOC_REMOVE_PYPI_START < DOC_REMOVE_PYPI_END
         ):
@@ -55,7 +55,7 @@ def _parse_requirements(file_path, requirements, links):
     :param requirements: pre-initialized set in which to store extracted package requirements.
     :param links: pre-initialized set in which to store extracted link reference requirements.
     """
-    with open(file_path, "r") as requirements_file:
+    with open(file_path, mode="r", encoding="utf-8") as requirements_file:
         for line in requirements_file:
             # ignore empty line, comment line or reference to other requirements file (-r flag)
             if not line or line.startswith("#") or line.startswith("-"):
diff --git a/tests/utils.py b/tests/utils.py
@@ -958,6 +958,7 @@ class FileServer(SimpleHTTPTestServer):
         This server takes more time to start than usual mocks. Use it sparingly, and consider maintaining a single
         instance over multiple tests of a complete test suite rather than recreating a server for each test.
     """
+
     def __init__(self):  # pylint: disable=W0231
         self._port = self.get_port()
         self._uri = f"http://0.0.0.0:{self._port}"
diff --git a/weaver/base.py b/weaver/base.py
@@ -117,6 +117,7 @@ class classproperty(property):  # pylint: disable=C0103,invalid-name
     .. seealso::
         https://stackoverflow.com/a/5191224
     """
+
     def __init__(
         self,
         fget=None,  # type: Optional[Callable[[object], PropertyDataTypeT]]
diff --git a/weaver/cli.py b/weaver/cli.py
@@ -2574,8 +2574,10 @@ def add_job_ref_param(parser):
     operation = parser.prog.split(" ")[-1]
     parser.add_argument(
         "-j", "--job", dest="job_reference", required=True,
-        help=f"Job URL or UUID to run {operation} operation. "
-             "If full Job URL is provided, the instance ``--url`` parameter can be omitted."
+        help=(
+            f"Job URL or UUID to run {operation} operation. "
+            "If full Job URL is provided, the instance ``--url`` parameter can be omitted."
+        )
     )
 
 
@@ -2856,6 +2858,7 @@ class ValidateAuthHandlerAction(argparse.Action):
     """
     Action that will validate that the input argument references an authentication handler that can be resolved.
     """
+
     def __call__(self, parser, namespace, auth_handler_ref, option_string=None):
         # type: (argparse.ArgumentParser, argparse.Namespace, Optional[str], Optional[str]) -> None
         """
@@ -2905,6 +2908,7 @@ class ValidateHeaderAction(argparse._AppendAction):  # noqa: W0212
 
         Header-Name: Header-Value
     """
+
     def __call__(self, parser, namespace, values, option_string=None):
         # type: (argparse.ArgumentParser, argparse.Namespace, Union[str, Sequence[Any], None], Optional[str]) -> None
         """
@@ -2939,6 +2943,7 @@ class ValidateNonZeroPositiveNumberAction(argparse.Action):
     """
     Action that will validate that the input argument is a positive number greater than zero.
     """
+
     def __call__(self, parser, namespace, values, option_string=None):
         # type: (argparse.ArgumentParser, argparse.Namespace, Union[str, Sequence[Any], None], Optional[str]) -> None
         """
diff --git a/weaver/utils.py b/weaver/utils.py
@@ -474,6 +474,7 @@ class SchemaRefResolver(JsonSchemaRefResolver):
     """
     # only need to override the remote resolution to add YAML support
     # init overload used to patch invalid typing definition
+
     def __init__(self, base_uri, referrer, *_, **__):
         # type: (str, OpenAPISchema, *Any, **Any) -> None
         super(SchemaRefResolver, self).__init__(base_uri, referrer, *_, **__)  # type: ignore
diff --git a/weaver/wps_restapi/colander_extras.py b/weaver/wps_restapi/colander_extras.py
@@ -131,6 +131,7 @@ class MetadataTypeConverter(TypeConverter):
     """
     Converter that applies :term:`OpenAPI` schema metadata properties defined in the schema node.
     """
+
     def convert_type(self, schema_node):
         result = super(MetadataTypeConverter, self).convert_type(schema_node)
         deprecated = getattr(schema_node, "deprecated", False)
@@ -648,6 +649,7 @@ class NoneType(colander.SchemaType):
     """
     Type representing an explicit :term:`JSON` ``null`` value.
     """
+
     def serialize(self, node, appstruct):  # noqa
         # type: (colander.SchemaNode, Any) -> Union[None, colander.null, colander.drop]
         if appstruct in (colander.null, colander.drop):
@@ -671,6 +673,7 @@ class AnyType(colander.SchemaType):
     """
     Type representing any :term:`JSON` structure.
     """
+
     def serialize(self, node, appstruct):  # noqa
         # type: (colander.SchemaNode, Any) -> Any
         return appstruct
@@ -2637,6 +2640,7 @@ class SchemaRefConverter(TypeConverter):
     """
     Converter that will add :term:`OpenAPI` ``$schema`` and ``$id`` references if they are provided in the schema node.
     """
+
     def convert_type(self, schema_node):
         # type: (colander.SchemaNode) -> OpenAPISchema
         result = super(SchemaRefConverter, self).convert_type(schema_node)
@@ -2653,6 +2657,7 @@ class ExtendedTypeConverter(SchemaRefConverter):
     """
     Base converter with support of `Extended` schema type definitions.
     """
+
     def convert_type(self, schema_node):
         # type: (colander.SchemaNode) -> OpenAPISchema
         # base type converters expect raw pattern string

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`	`files = {`
`11`	`11`	`"file": (`
`12`	`12`	`"desired-name.json",`
`13`		`- open(PATH, "r", encoding="utf-8"),`
	`13`	`+ open(PATH, mode="r", encoding="utf-8"), # pylint: disable=R1732`
`14`	`14`	`"application/json; charset=UTF-8"`
`15`	`15`	`)`
`16`	`16`	`}`