Skip to content

Commit a336295

Browse files
authored
Refactor service validation using CriteoService enum
1 parent 9678b37 commit a336295

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

scripts/shared/utils.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import subprocess
44
import logging
55
from datetime import datetime
6+
from .models.criteo_service import CriteoService
67

78
logger = None
89
formatted_date = None
@@ -20,8 +21,8 @@ def assert_criteo_service(directory_name):
2021
raise InvalidCriteoServiceException(f'Directory name for generated source doesn\'t have a valid format ({directory_name})')
2122

2223
criteo_service = splitted_directory_name[0].lower()
23-
24-
if criteo_service != 'marketingsolutions' and criteo_service != 'retailmedia' and criteo_service != 'commercegrid': # TODO use criteo_service.py ?
24+
known_services = {item.value for item in CriteoService}
25+
if criteo_service not in known_services:
2526
raise InvalidCriteoServiceException(f'Criteo Service found in directory name of generated source is invalid ({criteo_service})')
2627

2728
return criteo_service

0 commit comments

Comments
 (0)