Failure domains for multi-node CritControlPlane incorrect

[ChrisRx]

When creating a new CritControlPlane the expectation is that the new machines/nodes will be spread out over the available failure domains. Since all machines with cabpc are created simultaneously, the failure domain that is passed to the generated machines is the same one for all new machines/nodes. The expectation here is that these should be spread out over the available failure domains, so something like a NFailureDomainsWithFewestMachines will need to be applied here:

cluster-api-bootstrap-provider-crit/controllers/controlplane/controlplane.go

Lines 116 to 125 in 7c057e8

	// TODO(chrism): replace with NFailureDomainsWithFewestMachines so that
	// created control plane will be spread out over failure domains
	fd := controlPlane.FailureDomainWithFewestMachines()
	for i := 0; i < ccp.Spec.Replicas; i++ {
	if err := r.cloneConfigsAndGenerateMachine(ctx, cluster, ccp, bootstrapSpec, fd); err != nil {
	logger.Error(err, "failed to create initial control plane Machine")
	r.recorder.Eventf(ccp, corev1.EventTypeWarning, "FailedInitialization", "Failed to create initial control plane Machine for cluster %s/%s control plane: %v", cluster.Namespace, cluster.Name, err)
	return ctrl.Result{}, err
	}
	}