Removed unnecessary rubocop disable comments after last commit

Author: crmne

spec/ruby_llm/active_record/acts_as_attachment_spec.rb

@@ -32,7 +32,7 @@ def uploaded_file(path, type)
   end
 
   describe 'attachment handling' do
-    it 'converts ActiveStorage attachments to RubyLLM Content' do # rubocop:disable RSpec/ExampleLength,RSpec/MultipleExpectations
+    it 'converts ActiveStorage attachments to RubyLLM Content' do
       chat = Chat.create!(model_id: model)
 
       message = chat.messages.create!(role: 'user', content: 'Check this out')
@@ -47,7 +47,7 @@ def uploaded_file(path, type)
       expect(llm_message.content.attachments.first.mime_type).to eq('image/png')
     end
 
-    it 'handles multiple attachments' do # rubocop:disable RSpec/ExampleLength,RSpec/MultipleExpectations
+    it 'handles multiple attachments' do
       chat = Chat.create!(model_id: model)
 
       image_upload = uploaded_file(image_path, 'image/png')
@@ -60,7 +60,7 @@ def uploaded_file(path, type)
       expect(response.content).to be_present
     end
 
-    it 'handles attachments in ask method' do # rubocop:disable RSpec/ExampleLength,RSpec/MultipleExpectations
+    it 'handles attachments in ask method' do
       chat = Chat.create!(model_id: model)
 
       image_upload = uploaded_file(image_path, 'image/png')
@@ -74,7 +74,7 @@ def uploaded_file(path, type)
   end
 
   describe 'attachment types' do
-    it 'handles images' do # rubocop:disable RSpec/ExampleLength
+    it 'handles images' do
       chat = Chat.create!(model_id: model)
       message = chat.messages.create!(role: 'user', content: 'Image test')
 
@@ -89,7 +89,7 @@ def uploaded_file(path, type)
       expect(attachment.type).to eq(:image)
     end
 
-    it 'handles PDFs' do # rubocop:disable RSpec/ExampleLength
+    it 'handles PDFs' do
       chat = Chat.create!(model_id: model)
       message = chat.messages.create!(role: 'user', content: 'PDF test')
 

spec/ruby_llm/active_record/acts_as_spec.rb

@@ -20,7 +20,7 @@ def execute(expression:)
 
   # Basic functionality tests using dummy app models
   describe 'basic chat functionality' do
-    it 'persists chat history' do # rubocop:disable RSpec/ExampleLength,RSpec/MultipleExpectations
+    it 'persists chat history' do
       chat = Chat.create!(model_id: model)
       chat.ask("What's your favorite Ruby feature?")
 
@@ -33,7 +33,7 @@ def execute(expression:)
       expect(chat.updated_at).to eq(chat.messages.last.chat.updated_at)
     end
 
-    it 'tracks token usage' do # rubocop:disable RSpec/MultipleExpectations
+    it 'tracks token usage' do
       chat = Chat.create!(model_id: 'gpt-4.1-nano')
       chat.ask('Hello')
 
@@ -44,15 +44,15 @@ def execute(expression:)
   end
 
   describe 'system messages' do
-    it 'persists system messages' do # rubocop:disable RSpec/MultipleExpectations
+    it 'persists system messages' do
       chat = Chat.create!(model_id: model)
       chat.with_instructions('You are a Ruby expert')
 
       expect(chat.messages.first.role).to eq('system')
       expect(chat.messages.first.content).to eq('You are a Ruby expert')
     end
 
-    it 'replaces system messages when requested' do # rubocop:disable RSpec/ExampleLength,RSpec/MultipleExpectations
+    it 'replaces system messages when requested' do
       chat = Chat.create!(model_id: model)
 
       chat.with_instructions('Be helpful')
@@ -66,7 +66,7 @@ def execute(expression:)
   end
 
   describe 'tool usage' do
-    it 'persists tool calls' do # rubocop:disable RSpec/MultipleExpectations
+    it 'persists tool calls' do
       chat = Chat.create!(model_id: model)
       chat.with_tool(Calculator)
 
@@ -95,7 +95,7 @@ def execute(expression:)
   end
 
   describe 'structured output' do
-    it 'supports with_schema for structured responses' do # rubocop:disable RSpec/ExampleLength,RSpec/MultipleExpectations
+    it 'supports with_schema for structured responses' do
       chat = Chat.create!(model_id: model)
 
       schema = {
@@ -132,7 +132,7 @@ def execute(expression:)
   end
 
   describe 'error handling' do
-    it 'destroys empty assistant messages on API failure' do # rubocop:disable RSpec/MultipleExpectations
+    it 'destroys empty assistant messages on API failure' do
       chat = Chat.create!(model_id: model)
 
       # Stub the API to fail
@@ -210,7 +210,7 @@ class BotToolCall < ActiveRecord::Base # rubocop:disable Lint/ConstantDefinition
     end
 
     describe 'namespaced chat models' do
-      it 'works with namespaced classes and custom associations' do # rubocop:disable RSpec/ExampleLength,RSpec/MultipleExpectations
+      it 'works with namespaced classes and custom associations' do
         bot_chat = Assistants::BotChat.create!(model_id: model)
         bot_chat.ask("What's 2 + 2?")
 
@@ -221,7 +221,7 @@ class BotToolCall < ActiveRecord::Base # rubocop:disable Lint/ConstantDefinition
         expect(bot_chat.messages.last.content).to be_present
       end
 
-      it 'persists tool calls with custom classes' do # rubocop:disable RSpec/ExampleLength,RSpec/MultipleExpectations
+      it 'persists tool calls with custom classes' do
         bot_chat = Assistants::BotChat.create!(model_id: model)
         bot_chat.with_tool(Calculator)
 
@@ -233,7 +233,7 @@ class BotToolCall < ActiveRecord::Base # rubocop:disable Lint/ConstantDefinition
         expect(tool_call_message.tool_calls.first).to be_a(BotToolCall)
       end
 
-      it 'handles system messages correctly' do # rubocop:disable RSpec/MultipleExpectations
+      it 'handles system messages correctly' do
         bot_chat = Assistants::BotChat.create!(model_id: model)
         bot_chat.with_instructions('You are a helpful bot')
 
@@ -252,7 +252,7 @@ class BotToolCall < ActiveRecord::Base # rubocop:disable Lint/ConstantDefinition
     end
 
     describe 'to_llm conversion' do
-      it 'correctly converts custom messages to RubyLLM format' do # rubocop:disable RSpec/ExampleLength,RSpec/MultipleExpectations
+      it 'correctly converts custom messages to RubyLLM format' do
         bot_chat = Assistants::BotChat.create!(model_id: model)
         bot_message = bot_chat.messages.create!(
           role: 'user',
@@ -269,7 +269,7 @@ class BotToolCall < ActiveRecord::Base # rubocop:disable Lint/ConstantDefinition
         expect(llm_message.output_tokens).to eq(20)
       end
 
-      it 'correctly converts tool calls' do # rubocop:disable RSpec/ExampleLength,RSpec/MultipleExpectations
+      it 'correctly converts tool calls' do
         bot_chat = Assistants::BotChat.create!(model_id: model)
         bot_message = bot_chat.messages.create!(role: 'assistant', content: 'I need to calculate something')
 
@@ -317,7 +317,7 @@ def uploaded_file(path, type)
       )
     end
 
-    it 'converts ActiveStorage attachments to RubyLLM Content' do # rubocop:disable RSpec/ExampleLength,RSpec/MultipleExpectations
+    it 'converts ActiveStorage attachments to RubyLLM Content' do
       chat = Chat.create!(model_id: model)
 
       message = chat.messages.create!(role: 'user', content: 'Check this out')
@@ -332,7 +332,7 @@ def uploaded_file(path, type)
       expect(llm_message.content.attachments.first.mime_type).to eq('image/png')
     end
 
-    it 'handles multiple attachments' do # rubocop:disable RSpec/ExampleLength,RSpec/MultipleExpectations
+    it 'handles multiple attachments' do
       chat = Chat.create!(model_id: model)
 
       image_upload = uploaded_file(image_path, 'image/png')
@@ -345,7 +345,7 @@ def uploaded_file(path, type)
       expect(response.content).to be_present
     end
 
-    it 'handles attachments in ask method' do # rubocop:disable RSpec/ExampleLength,RSpec/MultipleExpectations
+    it 'handles attachments in ask method' do
       chat = Chat.create!(model_id: model)
 
       image_upload = uploaded_file(image_path, 'image/png')
@@ -358,7 +358,7 @@ def uploaded_file(path, type)
     end
 
     describe 'attachment types' do
-      it 'handles images' do # rubocop:disable RSpec/ExampleLength
+      it 'handles images' do
         chat = Chat.create!(model_id: model)
         message = chat.messages.create!(role: 'user', content: 'Image test')
 
@@ -373,7 +373,7 @@ def uploaded_file(path, type)
         expect(attachment.type).to eq(:image)
       end
 
-      it 'handles PDFs' do # rubocop:disable RSpec/ExampleLength
+      it 'handles PDFs' do
         chat = Chat.create!(model_id: model)
         message = chat.messages.create!(role: 'user', content: 'PDF test')
 

spec/ruby_llm/active_record/acts_as_with_context_spec.rb

@@ -19,7 +19,7 @@
       RubyLLM.instance_variable_set(:@config, original_config)
     end
 
-    it 'works when using chat with a custom context' do # rubocop:disable RSpec/ExampleLength,RSpec/MultipleExpectations
+    it 'works when using chat with a custom context' do
       chat = Chat.create!(model_id: model)
 
       # Create a custom context with API key
@@ -55,7 +55,7 @@
   describe 'with global configuration present' do
     include_context 'with configured RubyLLM'
 
-    it 'works with custom context even when global config exists' do # rubocop:disable RSpec/ExampleLength,RSpec/MultipleExpectations
+    it 'works with custom context even when global config exists' do
       chat = Chat.create!(model_id: model)
 
       # Create a different API key in custom context

spec/ruby_llm/chat_assume_model_exists_spec.rb

@@ -23,7 +23,7 @@
       end.to raise_error(ArgumentError, /Provider must be specified/)
     end
 
-    it 'skips registry validation when assuming model exists' do # rubocop:disable RSpec/ExampleLength,RSpec/MultipleExpectations
+    it 'skips registry validation when assuming model exists' do
       expect(RubyLLM::Models).not_to receive(:find) # rubocop:disable RSpec/MessageSpies
 
       chat = described_class.new(
@@ -36,7 +36,7 @@
       expect(chat.model.provider).to eq(provider)
     end
 
-    it 'works with RubyLLM.chat convenience method' do # rubocop:disable RSpec/ExampleLength
+    it 'works with RubyLLM.chat convenience method' do
       chat = RubyLLM.chat(
         model: custom_model,
         provider: provider,
@@ -46,7 +46,7 @@
       expect(chat.model.id).to eq(custom_model)
     end
 
-    it 'works with models not in registry but available in API' do # rubocop:disable RSpec/ExampleLength,RSpec/MultipleExpectations
+    it 'works with models not in registry but available in API' do
       # Simulate model missing from registry
       filtered_models = original_models.reject { |m| m.id == real_model }
       RubyLLM::Models.instance.instance_variable_set(:@models, filtered_models)
@@ -68,7 +68,7 @@
       expect(response.content).to include('4')
     end
 
-    it 'works with with_model method' do # rubocop:disable RSpec/MultipleExpectations
+    it 'works with with_model method' do
       chat = RubyLLM.chat
 
       chat.with_model(custom_model, provider: provider, assume_exists: true)

spec/ruby_llm/chat_content_spec.rb

@@ -22,7 +22,7 @@
     CHAT_MODELS.each do |model_info|
       model = model_info[:model]
       provider = model_info[:provider]
-      it "#{provider}/#{model} can understand text" do # rubocop:disable RSpec/MultipleExpectations,RSpec/ExampleLength
+      it "#{provider}/#{model} can understand text" do
         chat = RubyLLM.chat(model: model, provider: provider)
         response = chat.ask("What's in this file?", with: text_path)
 
@@ -41,7 +41,7 @@
         expect(chat.messages[2].content.attachments.first.mime_type).to eq('application/xml')
       end
 
-      it "#{provider}/#{model} can understand remote text" do # rubocop:disable RSpec/MultipleExpectations,RSpec/ExampleLength
+      it "#{provider}/#{model} can understand remote text" do
         chat = RubyLLM.chat(model: model, provider: provider)
         response = chat.ask("What's in this file?", with: text_url)
 
@@ -58,7 +58,7 @@
     VISION_MODELS.each do |model_info|
       model = model_info[:model]
       provider = model_info[:provider]
-      it "#{provider}/#{model} can understand local images" do # rubocop:disable RSpec/MultipleExpectations,RSpec/ExampleLength
+      it "#{provider}/#{model} can understand local images" do
         chat = RubyLLM.chat(model: model, provider: provider)
         response = chat.ask('What do you see in this image?', with: { image: image_path })
 
@@ -69,7 +69,7 @@
         expect(chat.messages.first.content.attachments.first.mime_type).to eq('image/png')
       end
 
-      it "#{provider}/#{model} can understand remote images without extension" do # rubocop:disable RSpec/MultipleExpectations,RSpec/ExampleLength
+      it "#{provider}/#{model} can understand remote images without extension" do
         chat = RubyLLM.chat(model: model, provider: provider)
         response = chat.ask('What do you see in this image?', with: image_url_no_ext)
 
@@ -82,7 +82,7 @@
     end
     model = VISION_MODELS.first[:model]
     provider = VISION_MODELS.first[:provider]
-    it "return errors when content doesn't exist" do # rubocop:disable RSpec/ExampleLength,RSpec/MultipleExpectations
+    it "return errors when content doesn't exist" do
       chat = RubyLLM.chat(model: model, provider: provider)
       expect do
         chat.ask('What do you see in this image?', with: bad_image_url)
@@ -99,7 +99,7 @@
     AUDIO_MODELS.each do |model_info|
       model = model_info[:model]
       provider = model_info[:provider]
-      it "#{provider}/#{model} can understand audio" do # rubocop:disable RSpec/MultipleExpectations,RSpec/ExampleLength
+      it "#{provider}/#{model} can understand audio" do
         chat = RubyLLM.chat(model: model, provider: provider)
         response = chat.ask('What is being said?', with: { audio: audio_path })
 
@@ -116,7 +116,7 @@
     PDF_MODELS.each do |model_info|
       model = model_info[:model]
       provider = model_info[:provider]
-      it "#{provider}/#{model} understands PDFs" do # rubocop:disable RSpec/MultipleExpectations,RSpec/ExampleLength
+      it "#{provider}/#{model} understands PDFs" do
         chat = RubyLLM.chat(model: model, provider: provider)
         response = chat.ask('Summarize this document', with: { pdf: pdf_path })
         expect(response.content).not_to be_empty
@@ -128,7 +128,7 @@
         expect(response.content).not_to be_empty
       end
 
-      it "#{provider}/#{model} handles multiple PDFs" do # rubocop:disable RSpec/MultipleExpectations,RSpec/ExampleLength
+      it "#{provider}/#{model} handles multiple PDFs" do
         chat = RubyLLM.chat(model: model, provider: provider)
         # Using same file twice for testing
         response = chat.ask('Compare these documents', with: [pdf_path, pdf_url])
@@ -143,7 +143,7 @@
         expect(response.content).not_to be_empty
       end
 
-      it "#{provider}/#{model} can handle array of mixed files with auto-detection" do # rubocop:disable RSpec/ExampleLength,RSpec/MultipleExpectations
+      it "#{provider}/#{model} can handle array of mixed files with auto-detection" do
         chat = RubyLLM.chat(model: model, provider: provider)
         response = chat.ask('Analyze these files', with: [image_path, pdf_path])
 
@@ -164,14 +164,14 @@
       expect(attachment.mime_type).to be_present
     end
 
-    it 'creates content with URL attachments' do # rubocop:disable RSpec/MultipleExpectations
+    it 'creates content with URL attachments' do
       content = RubyLLM::Content.new('Describe this image', image_url)
 
       expect(content.attachments).not_to be_empty
       expect(content.attachments.first).to be_a(RubyLLM::Attachment)
     end
 
-    it 'prevents ArgumentError: wrong number of arguments when processing URL attachments' do # rubocop:disable RSpec/MultipleExpectations
+    it 'prevents ArgumentError: wrong number of arguments when processing URL attachments' do
       require 'open-uri' # required to trigger the marcel/open-uri compatibility issue
 
       attachment = RubyLLM::Attachment.new(image_url)

spec/ruby_llm/chat_error_spec.rb

@@ -43,7 +43,7 @@
           end
         end
 
-        it 'raises appropriate auth error' do # rubocop:disable RSpec/ExampleLength,RSpec/MultipleExpectations
+        it 'raises appropriate auth error' do
           skip('Only valid for remote providers') if RubyLLM::Provider.providers[provider].local?
           expect { chat.ask('Hello') }.to raise_error do |error|
             expect(error).to be_a(RubyLLM::Error)
@@ -67,7 +67,7 @@
       context "#{provider}/#{model}" do # rubocop:disable RSpec/ContextWording
         let(:chat) { RubyLLM.chat(model: model, provider: provider) }
 
-        it 'handles context length exceeded errors' do # rubocop:disable RSpec/ExampleLength,RSpec/MultipleExpectations
+        it 'handles context length exceeded errors' do
           if RubyLLM::Provider.providers[provider]&.local?
             skip('Local providers do not throw an error for context length exceeded')
           end