-
-
Notifications
You must be signed in to change notification settings - Fork 359
Ephemeral #prompt vs persistent #ask & include_attachments option #516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nativestranger
wants to merge
13
commits into
crmne:main
Choose a base branch
from
nativestranger:prompt-and-attachment-windowing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ephemeral #prompt vs persistent #ask & include_attachments option #516
nativestranger
wants to merge
13
commits into
crmne:main
from
nativestranger:prompt-and-attachment-windowing
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Considering #509 It does feel a bit weird to me how |
|
+1 could use this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Adds two complementary features to RubyLLM:
1.
prompt()method - Non-persisting chat interactionsA new method that works like
ask()but doesn't persist anything to the database. Perfect for:A/B testing example
Then add create an assistant message with both responses and a 'choose' action. When user picks best answer, then we manually persist the winner (with backfilled tool calls if desired) removing the A/B selection content, replacing it with the selected response.
2.
include_attachments:parameter - Performance optimizationAdded optional parameter to
Message#to_llm()to skip attachment downloads:Window attachments: apply arbitrary logic to which messages ought have their attachments downloaded for each chat run
Why this matters:
true(backward compatible)Type of change
Scope check
Why this belongs in RubyLLM:
prompt()is a fundamental LLM interaction pattern (likeask()but non-persisting)Quality check
overcommit --installand all hooks passbundle exec rake vcr:record[provider_name]- Requires maintainer with API credentialsmodels.json,aliases.json)Test Coverage:
prompt()methodinclude_attachments:parameter (all passing)API changes
Chat#prompt(message, with: nil, &block)(both new and legacy APIs)Message#prompt_messages(singleton method on response) for accessibilityMessage#to_llm(include_attachments: true)(optional parameter, defaults totrue)Backward Compatibility:
include_attachments:defaults totrue(existing behavior unchanged)prompt()is additiveuse_new_acts_asconfig)Related issues
Not sure.