Do not create the wallet struct directly; instead, call new.

The bug comes with the SQLx-sqlite pool bug, where several connections are
created by default, but the `new` function takes care of that, fixing that bug
by making a single instance of the database.

If constructed directly, the pool would create several connections to the
database, which in most instances is fine, but with SQLite :memory: each
connection is entirely independent.

Author: crodas

crates/cdk-sqlite/src/wallet/memory.rs

@@ -6,11 +6,7 @@ use super::WalletSqliteDatabase;
 
 /// Creates a new in-memory [`WalletSqliteDatabase`] instance
 pub async fn empty() -> Result<WalletSqliteDatabase, Error> {
-    let db = WalletSqliteDatabase {
-        pool: sqlx::sqlite::SqlitePool::connect(":memory:")
-            .await
-            .map_err(|e| Error::Database(Box::new(e)))?,
-    };
+    let db = WalletSqliteDatabase::new(":memory:").await?;
     db.migrate().await;
     Ok(db)
 }