A better list of silenceable network errors; also typo in the name Silenceable

Author: crontab

AsyncMux/Sources/AsyncError.swift

@@ -21,28 +21,36 @@ public struct HTTPError: LocalizedError {
 }
 
 
-public struct SilencableError: LocalizedError {
+public struct SilenceableError: LocalizedError {
     let wrapped: Error?
 
     public init(wrapped: Error?) {
         self.wrapped = wrapped
     }
 
     public var errorDescription: String? {
-        wrapped?.localizedDescription ?? "SilencableError"
+        wrapped?.localizedDescription ?? "SilenceableError"
     }
 }
 
 
 public extension Error {
 
-    var isSilencable: Bool {
+    var isSilenceable: Bool {
         if (self as NSError).domain == NSURLErrorDomain {
-            return [NSURLErrorNotConnectedToInternet, NSURLErrorNetworkConnectionLost, NSURLErrorCannotConnectToHost].contains((self as NSError).code)
+            // No connection?
+            return [
+                NSURLErrorCannotFindHost,
+                NSURLErrorCannotConnectToHost,
+                NSURLErrorNetworkConnectionLost,
+                NSURLErrorNotConnectedToInternet,
+                NSURLErrorSecureConnectionFailed,
+                NSURLErrorBackgroundSessionInUseByAnotherProcess
+            ].contains((self as NSError).code)
         }
-        if self is SilencableError {
-            return true
+        else {
+            // Otherwise, user-defined silenceable error?
+            return self is SilenceableError
         }
-        return false
     }
 }

AsyncMux/Sources/Multiplexer.swift

@@ -131,7 +131,7 @@ public final class Multiplexer<T: Codable & Sendable>: MuxRepositoryProtocol {
                     return try await onFetch()
                 }
                 catch {
-                    if error.isSilencable {
+                    if error.isSilenceable {
                         if let storedValue {
                             return storedValue
                         }

AsyncMuxDemo/Sources/WeatherAPI.swift

@@ -51,9 +51,9 @@ final class WeatherAPI {
         }
         catch {
             print("ERROR:", error)
-            // When there's no connection CoreLocation returns the below error; we convert it to a silencable one
+            // When there's no connection CoreLocation returns the below error; we convert it to a silenceable one
             if (error as NSError).domain == kCLErrorDomain, (error as NSError).code == 2 {
-                throw SilencableError(wrapped: error)
+                throw SilenceableError(wrapped: error)
             }
             throw error
         }

README.md

@@ -90,13 +90,13 @@ let myProfile = Multiplexer<UserProfile>(cacheKey: "MyProfile") {
 }
 ```
 
-The objects stored on disk can be reused by the multiplexer even after TTL expires if your `onFetch` fails due to a connectivity problem. You can additionally tell the multiplexer to ignore the error and fetch the cached object by throwing a `SilencableError` in your `onFetch` method.
+The objects stored on disk can be reused by the multiplexer even after TTL expires if your `onFetch` fails due to a connectivity problem. You can additionally tell the multiplexer to ignore the error and fetch the cached object by throwing a `SilenceableError` in your `onFetch` method.
 
 The disk storage method is currently hardcoded but will be possible to override in the future releases of the library.
 
 At run time, you can invalidate the cached object using one of the following methods:
 
-- "Soft refresh": chain the `refresh()` method with a call to `request()`: the multiplexer will attempt to fetch the object again, but will not discard the existing cached objects in memory or on disk. In case of a silencable error (i.e. connectivity issue) the older cached object will be used again as a result.
+- "Soft refresh": chain the `refresh()` method with a call to `request()`: the multiplexer will attempt to fetch the object again, but will not discard the existing cached objects in memory or on disk. In case of a silenceable error (i.e. connectivity issue) the older cached object will be used again as a result.
 - "Hard refresh": call `clear()` to discard both memory and disk caches for a given object. The next call to `request()` will attempt to fetch the object and will fail in case of an error.
 
 More detailed descriptions on each method can be found in the source file [Multiplexer.swift](AsyncMux/Sources/Multiplexer.swift).