Fix pull flags.

Author: Alexhuszagh

.github/workflows/ci.yml

@@ -284,15 +284,13 @@ jobs:
         id: build-docker-image
         if: steps.prepare-meta.outputs.has-image
         timeout-minutes: 120
-        # TODO(ahuszagh) Remove this multiline and docker images
-        run: |
-          docker images
-          cargo xtask build-docker-image -v "${TARGET}${SUB:+.$SUB}"
+        run: cargo xtask build-docker-image -v "${TARGET}${SUB:+.$SUB}"
         env:
           TARGET: ${{ matrix.target }}
           SUB: ${{ matrix.sub }}
           LABELS: ${{ steps.docker-meta.outputs.labels }}
           LATEST: ${{ needs.check.outputs.is-latest || 'false' }}
+          CROSS_CONTAINER_ENGINE_NO_PULL: true
         shell: bash
 
       - name: Set Docker image for test

src/docker/engine.rs

@@ -71,6 +71,7 @@ pub struct Engine {
 impl Engine {
     pub const CROSS_CONTAINER_ENGINE_NO_BUILDKIT_ENV: &'static str =
         "CROSS_CONTAINER_ENGINE_NO_BUILDKIT";
+    pub const CROSS_CONTAINER_ENGINE_NO_PULL_ENV: &'static str = "CROSS_CONTAINER_ENGINE_NO_PULL";
     pub fn new(
         in_docker: Option<bool>,
         is_remote: Option<bool>,
@@ -141,6 +142,15 @@ impl Engine {
             .map(|x| bool_from_envvar(&x))
             .unwrap_or_default()
     }
+
+    // if any of the base images do not exist in the registry, even
+    // if they exist locally, attempting to pull will fail
+    #[must_use]
+    pub fn should_pull() -> bool {
+        !env::var(Self::CROSS_CONTAINER_ENGINE_NO_PULL_ENV)
+            .map(|x| bool_from_envvar(&x))
+            .unwrap_or_default()
+    }
 }
 
 // determine if the container engine is docker. this fixes issues with

xtask/src/build_docker_image.rs

@@ -218,7 +218,7 @@ pub fn build_docker_image(
             tags = vec![target.image_name(&repository, tag)];
         }
 
-        if engine.kind.supports_pull_flag() {
+        if docker::Engine::should_pull() && engine.kind.supports_pull_flag() {
             docker_build.arg("--pull");
         }
         if no_cache {