CI: Replace deprecated ::set-output command

Author: guihkx

.github/actions/cargo-install-upload-artifacts/action.yml

@@ -14,7 +14,7 @@ runs:
         metadata="$(cargo metadata --format-version 1 --no-deps)"
 
         package_name="cross"
-        echo "::set-output name=package-name::${package_name}"
+        echo "package-name=${package_name}" >> $GITHUB_OUTPUT
 
         out_dir="$(mktemp -d)"
         artifacts_dir="$(mktemp -d)"
@@ -24,8 +24,8 @@ runs:
           artifacts_dir="$(cygpath -w "${artifacts_dir}")"
         fi
 
-        echo "::set-output name=out-dir::${out_dir}"
-        echo "::set-output name=artifacts-dir::${artifacts_dir}"
+        echo "out-dir=${out_dir}" >> $GITHUB_OUTPUT
+        echo "artifacts-dir=${artifacts_dir}" >> $GITHUB_OUTPUT
       shell: bash
     - run: rm -rf .git
       shell: bash
@@ -66,8 +66,8 @@ runs:
           artifact_path="$(cygpath -w "${artifact_path}")"
         fi
 
-        echo "::set-output name=name::${artifact_name}"
-        echo "::set-output name=path::${artifact_path}"
+        echo "name=${artifact_name}" >> $GITHUB_OUTPUT
+        echo "path=${artifact_path}" >> $GITHUB_OUTPUT
       env:
         package_name: ${{ steps.metadata.outputs.package-name }}
         out_dir: ${{ steps.metadata.outputs.out-dir }}

.github/actions/cargo-llvm-cov/action.yml

@@ -31,7 +31,7 @@ runs:
           echo LLVM_PROFILE_FILE="${pwd}/target/cross-%m.profraw" >> $GITHUB_ENV
           echo CARGO_INCREMENTAL="0" >> $GITHUB_ENV
           echo RUST_TEST_THREADS="1" >> $GITHUB_ENV
-          echo "::set-output name=artifact-name::_coverage-${name}"
+          echo "artifact-name=_coverage-${name}" >> $GITHUB_OUTPUT
         post: |
           # XXX(emilgardis): Upload early?
           pwd=$(pwd)

.github/workflows/ci.yml

@@ -385,7 +385,7 @@ jobs:
         with:
           path: ${{ runner.temp }}/artifacts
       - name: Grab PR number
-        run: echo "::set-output name=pr::"$(echo $commit_message | sed -ne  's/.*\#\(.*\):/\1/p')
+        run: echo "pr=$(echo ${commit_message} | sed -ne 's/.*#\(.*\):/\1/p')" >> $GITHUB_OUTPUT
         id: pr-number
         if: ${{ !github.event.pull_request.number }}
         env:

xtask/src/build_docker_image.rs

@@ -324,8 +324,8 @@ pub fn build_docker_image(
             }
         }
         if gha {
-            gha_output("image", &tags[0]);
-            gha_output("images", &format!("'{}'", serde_json::to_string(&tags)?));
+            gha_output("image", &tags[0])?;
+            gha_output("images", &format!("'{}'", serde_json::to_string(&tags)?))?;
             if targets.len() > 1 {
                 gha_print("::endgroup::");
             }

xtask/src/ci.rs

@@ -63,7 +63,7 @@ pub fn ci(args: CiJob, metadata: CargoMetadata) -> cross::Result<()> {
                 chrono::Utc::now().to_rfc3339_opts(chrono::SecondsFormat::Millis, true)
             ));
 
-            gha_output("labels", &serde_json::to_string(&labels.join("\n"))?);
+            gha_output("labels", &serde_json::to_string(&labels.join("\n"))?)?;
 
             let version = cross_meta.version.clone();
 
@@ -78,15 +78,15 @@ pub fn ci(args: CiJob, metadata: CargoMetadata) -> cross::Result<()> {
                     false,
                     &version,
                 )?[0],
-            );
+            )?;
 
             if target.has_ci_image() {
-                gha_output("has-image", "true")
+                gha_output("has-image", "true")?
             }
             if target.is_standard_target_image() {
-                gha_output("test-variant", "default")
+                gha_output("test-variant", "default")?
             } else {
-                gha_output("test-variant", &target.name)
+                gha_output("test-variant", &target.name)?
             }
         }
         CiJob::Check { ref_type, ref_name } => {
@@ -110,7 +110,7 @@ pub fn ci(args: CiJob, metadata: CargoMetadata) -> cross::Result<()> {
                         .ok_or_else(|| eyre::eyre!("cargo search returned unexpected data"))?,
                 )?;
                 if version >= latest_version && version.pre.is_empty() {
-                    gha_output("is-latest", "true")
+                    gha_output("is-latest", "true")?
                 }
             }
         }

xtask/src/ci/target_matrix.rs

@@ -45,7 +45,7 @@ pub(crate) fn run(message: String, author: String) -> Result<(), color_eyre::Rep
 
     let json = serde_json::to_string(&matrix)?;
     gha_print(&json);
-    gha_output("matrix", &json);
+    gha_output("matrix", &json)?;
     Ok(())
 }
 

xtask/src/util.rs

@@ -1,3 +1,4 @@
+use std::env;
 use std::fs;
 use std::io::Write;
 use std::path::{Path, PathBuf};
@@ -296,12 +297,13 @@ pub fn gha_error(content: &str) {
 }
 
 #[track_caller]
-pub fn gha_output(tag: &str, content: &str) {
+pub fn gha_output(tag: &str, content: &str) -> cross::Result<()> {
     if content.contains('\n') {
         // https://github.com/actions/toolkit/issues/403
-        panic!("output `{tag}` contains newlines, consider serializing with json and deserializing in gha with fromJSON()")
+        eyre::bail!("output `{tag}` contains newlines, consider serializing with json and deserializing in gha with fromJSON()");
     }
-    gha_output!("::set-output name={tag}::{}", content);
+    write_to_gha_env_file("GITHUB_OUTPUT", &format!("{tag}={content}"))?;
+    Ok(())
 }
 
 pub fn read_dockerfiles(msg_info: &mut MessageInfo) -> cross::Result<Vec<(PathBuf, String)>> {
@@ -411,3 +413,12 @@ pub fn write_to_string(path: &Path, contents: &str) -> cross::Result<()> {
     writeln!(file, "{}", contents)?;
     Ok(())
 }
+
+// https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#environment-files
+pub fn write_to_gha_env_file(env_name: &str, contents: &str) -> cross::Result<()> {
+    let path = env::var(env_name)?;
+    let path = Path::new(&path);
+    let mut file = fs::OpenOptions::new().append(true).open(path)?;
+    writeln!(file, "{}", contents)?;
+    Ok(())
+}