Remove unused variable.

reitermarkus · reitermarkus · commit 69bff31c8e1e · 2019-11-22T15:12:15.000+01:00
diff --git a/docker/Dockerfile.aarch64-linux-android b/docker/Dockerfile.aarch64-linux-android
@@ -14,7 +14,7 @@ COPY android-system.sh /
 RUN /android-system.sh arm64
 
 COPY qemu.sh /
-RUN /qemu.sh aarch64 android
+RUN /qemu.sh aarch64
 
 RUN cp /android-ndk/sysroot/usr/lib/libz.so /system/lib/
 
diff --git a/docker/Dockerfile.aarch64-unknown-linux-gnu b/docker/Dockerfile.aarch64-unknown-linux-gnu
@@ -15,7 +15,7 @@ RUN apt-get install -y --no-install-recommends \
     libc6-dev-arm64-cross
 
 COPY qemu.sh /
-RUN /qemu.sh aarch64 linux softmmu
+RUN /qemu.sh aarch64 softmmu
 
 COPY dropbear.sh /
 RUN /dropbear.sh
diff --git a/docker/Dockerfile.arm-linux-androideabi b/docker/Dockerfile.arm-linux-androideabi
@@ -14,7 +14,7 @@ COPY android-system.sh /
 RUN /android-system.sh arm
 
 COPY qemu.sh /
-RUN /qemu.sh arm android
+RUN /qemu.sh arm
 
 RUN cp /android-ndk/sysroot/usr/lib/libz.so /system/lib/
 
diff --git a/docker/Dockerfile.armv7-linux-androideabi b/docker/Dockerfile.armv7-linux-androideabi
@@ -14,7 +14,7 @@ COPY android-system.sh /
 RUN /android-system.sh arm
 
 COPY qemu.sh /
-RUN /qemu.sh arm android
+RUN /qemu.sh arm
 
 RUN cp /android-ndk/sysroot/usr/lib/libz.so /system/lib/
 
diff --git a/docker/Dockerfile.armv7-unknown-linux-gnueabihf b/docker/Dockerfile.armv7-unknown-linux-gnueabihf
@@ -15,7 +15,7 @@ RUN apt-get install -y --no-install-recommends \
     libc6-dev-armhf-cross
 
 COPY qemu.sh /
-RUN /qemu.sh arm linux softmmu
+RUN /qemu.sh arm softmmu
 
 COPY dropbear.sh /
 RUN /dropbear.sh
diff --git a/docker/Dockerfile.i686-linux-android b/docker/Dockerfile.i686-linux-android
@@ -21,7 +21,7 @@ RUN /android-system.sh x86
 #
 # Running with qemu works as expected
 COPY qemu.sh /
-RUN /qemu.sh i386 android
+RUN /qemu.sh i386
 
 RUN cp /android-ndk/sysroot/usr/lib/libz.so /system/lib/
 
diff --git a/docker/Dockerfile.i686-unknown-linux-gnu b/docker/Dockerfile.i686-unknown-linux-gnu
@@ -14,7 +14,7 @@ RUN apt-get install -y --no-install-recommends \
     g++-multilib
 
 COPY qemu.sh /
-RUN /qemu.sh i386 linux softmmu
+RUN /qemu.sh i386 softmmu
 
 COPY dropbear.sh /
 RUN /dropbear.sh
diff --git a/docker/Dockerfile.mips-unknown-linux-gnu b/docker/Dockerfile.mips-unknown-linux-gnu
@@ -11,7 +11,7 @@ RUN apt-get install -y --no-install-recommends \
     libc6-dev-mips-cross
 
 COPY qemu.sh /
-RUN /qemu.sh mips linux softmmu
+RUN /qemu.sh mips softmmu
 
 COPY dropbear.sh /
 RUN /dropbear.sh
diff --git a/docker/Dockerfile.mips64el-unknown-linux-gnuabi64 b/docker/Dockerfile.mips64el-unknown-linux-gnuabi64
@@ -11,7 +11,7 @@ RUN apt-get install -y --no-install-recommends \
     libc6-dev-mips64el-cross
 
 COPY qemu.sh /
-RUN /qemu.sh mips64el linux softmmu
+RUN /qemu.sh mips64el softmmu
 
 COPY dropbear.sh /
 RUN /dropbear.sh
diff --git a/docker/Dockerfile.mipsel-unknown-linux-gnu b/docker/Dockerfile.mipsel-unknown-linux-gnu
@@ -11,7 +11,7 @@ RUN apt-get install -y --no-install-recommends \
     libc6-dev-mipsel-cross
 
 COPY qemu.sh /
-RUN /qemu.sh mipsel linux softmmu
+RUN /qemu.sh mipsel softmmu
 
 COPY dropbear.sh /
 RUN /dropbear.sh
diff --git a/docker/Dockerfile.powerpc-unknown-linux-gnu b/docker/Dockerfile.powerpc-unknown-linux-gnu
@@ -15,7 +15,7 @@ RUN apt-get install -y --no-install-recommends \
     libc6-dev-powerpc-cross
 
 COPY qemu.sh /
-RUN /qemu.sh ppc linux softmmu
+RUN /qemu.sh ppc softmmu
 
 COPY dropbear.sh /
 RUN /dropbear.sh
diff --git a/docker/Dockerfile.powerpc64-unknown-linux-gnu b/docker/Dockerfile.powerpc64-unknown-linux-gnu
@@ -11,7 +11,7 @@ RUN apt-get install -y --no-install-recommends \
     libc6-dev-ppc64-cross
 
 COPY qemu.sh /
-RUN /qemu.sh ppc64 linux softmmu
+RUN /qemu.sh ppc64 softmmu
 
 COPY dropbear.sh /
 RUN /dropbear.sh
diff --git a/docker/Dockerfile.powerpc64le-unknown-linux-gnu b/docker/Dockerfile.powerpc64le-unknown-linux-gnu
@@ -11,7 +11,7 @@ RUN apt-get install -y --no-install-recommends \
     libc6-dev-ppc64el-cross
 
 COPY qemu.sh /
-RUN /qemu.sh ppc64le linux softmmu
+RUN /qemu.sh ppc64le softmmu
 
 COPY dropbear.sh /
 RUN /dropbear.sh
diff --git a/docker/Dockerfile.s390x-unknown-linux-gnu b/docker/Dockerfile.s390x-unknown-linux-gnu
@@ -11,7 +11,7 @@ RUN apt-get install -y --no-install-recommends \
     libc6-dev-s390x-cross
 
 COPY qemu.sh /
-RUN /qemu.sh s390x linux softmmu
+RUN /qemu.sh s390x softmmu
 
 COPY dropbear.sh /
 RUN /dropbear.sh
diff --git a/docker/Dockerfile.sparc64-unknown-linux-gnu b/docker/Dockerfile.sparc64-unknown-linux-gnu
@@ -11,7 +11,7 @@ RUN apt-get install -y --no-install-recommends \
     libc6-dev-sparc64-cross
 
 COPY qemu.sh /
-RUN /qemu.sh sparc64 linux softmmu
+RUN /qemu.sh sparc64 softmmu
 
 COPY dropbear.sh /
 RUN /dropbear.sh
diff --git a/docker/Dockerfile.x86_64-linux-android b/docker/Dockerfile.x86_64-linux-android
@@ -15,7 +15,7 @@ RUN /android-system.sh x86_64
 
 # Using qemu allows older host cpus (without sse4) to execute the target binaries
 COPY qemu.sh /
-RUN /qemu.sh x86_64 android
+RUN /qemu.sh x86_64
 
 RUN cp /android-ndk/sysroot/usr/lib/libz.so /system/lib/
 
diff --git a/docker/Dockerfile.x86_64-unknown-linux-gnu b/docker/Dockerfile.x86_64-unknown-linux-gnu
@@ -15,7 +15,7 @@ RUN apt-get install -y --no-install-recommends \
     zlib1g-dev
 
 COPY qemu.sh /
-RUN /qemu.sh x86_64 linux softmmu
+RUN /qemu.sh x86_64 softmmu
 
 COPY dropbear.sh /
 RUN /dropbear.sh
diff --git a/docker/qemu.sh b/docker/qemu.sh
@@ -16,8 +16,7 @@ main() {
     fi
 
     local arch=$1 \
-          os=$2 \
-          softmmu=$3 \
+          softmmu=${2:-} \
           td=$(mktemp -d)
 
     local dependencies=(

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ RUN /android-system.sh x86`
`21`	`21`	`#`
`22`	`22`	`# Running with qemu works as expected`
`23`	`23`	`COPY qemu.sh /`
`24`		`-RUN /qemu.sh i386 android`
	`24`	`+RUN /qemu.sh i386`
`25`	`25`
`26`	`26`	`RUN cp /android-ndk/sysroot/usr/lib/libz.so /system/lib/`
`27`	`27`