improve changelog xtask (#1426)

Author: Emilgardis

.changes/1403-1411.json

@@ -5,5 +5,5 @@
 },
  {
      "type": "added",
-     "description": "Added helper script `/freebsd-install-package.sh` and friends to install freebsd packages, see [wiki](https://github.com/cross-rs/cross/wiki/FAQ#custom-images)",
+     "description": "Added helper script `/freebsd-install-package.sh` and friends to install freebsd packages, see [wiki](https://github.com/cross-rs/cross/wiki/FAQ#custom-images)"
  }]

.github/workflows/changelog.yml

@@ -20,7 +20,7 @@ jobs:
           files: |
             .changes/*.json
 
-      - name: Validate Changelog Files
+      - name: Validate Changelog
         id: changelog
         run: |
           set -x
@@ -34,10 +34,6 @@ jobs:
               echo "Must add or remove changes or add the 'no changelog' label"
               exit 1
             else
-              basenames=()
-              for path in "${added_modified[@]}"; do
-                basenames+=($(basename "${path}"))
-              done
-              cargo xtask changelog validate "${basenames[@]}"
+              cargo xtask changelog validate
             fi
           fi

xtask/src/changelog.rs

@@ -6,10 +6,10 @@ use std::path::Path;
 
 use crate::util::{project_dir, write_to_string};
 use cross::shell::MessageInfo;
+use cross::ToUtf8;
 
 use chrono::{Datelike, Utc};
 use clap::{Args, Subcommand};
-use cross::ToUtf8;
 use eyre::Context;
 use serde::Deserialize;
 
@@ -516,7 +516,7 @@ pub fn validate_changelog(
 ) -> cross::Result<()> {
     let root = project_dir(msg_info)?;
     let changes_dir = root.join(".changes");
-    if files.is_empty() && std::env::var("GITHUB_ACTIONS").is_err() {
+    if files.is_empty() {
         files = fs::read_dir(&changes_dir)?
             .filter_map(|x| x.ok())
             .filter(|x| x.file_type().map_or(false, |v| v.is_file()))