Appease clippy

Author: petehayes102

src/build.rs

@@ -24,6 +24,9 @@ fn main() {
         .write_all(commit_info().as_bytes())
         .unwrap();
 
+    // Add "cross_sandboxed" to list of approved cfgs
+    println!("cargo::rustc-check-cfg=cfg(cross_sandboxed)");
+
     if env::var("CROSS_SANDBOXED").is_ok() {
         println!("cargo:rustc-cfg=cross_sandboxed");
     }

src/config.rs

@@ -259,12 +259,9 @@ impl Config {
             for mentioned_target in keys {
                 let mentioned_target_norm = mentioned_target
                     .to_string()
-                    .replace(|c| c == '-' || c == '_', "")
-                    .to_lowercase();
-                let target_norm = target
-                    .to_string()
-                    .replace(|c| c == '-' || c == '_', "")
+                    .replace(['-', '_'], "")
                     .to_lowercase();
+                let target_norm = target.to_string().replace(['-', '_'], "").to_lowercase();
                 if mentioned_target != target && mentioned_target_norm == target_norm {
                     msg_info.warn(format_args!("a target named \"{mentioned_target}\" is mentioned in the Cross configuration, but the current specified target is \"{target}\"."))?;
                     msg_info.status(" > Is the target misspelled in the Cross configuration?")?;

src/docker/custom.rs

@@ -266,7 +266,7 @@ fn docker_tag_name(file_name: &str) -> String {
 
     // in case our result ends in an invalid last char `-` or `.`
     // we remove
-    result = result.trim_end_matches(&['.', '-']).to_owned();
+    result = result.trim_end_matches(['.', '-']).to_owned();
 
     // in case all characters were invalid or we had all non-ASCII
     // characters followed by a `-` or `.`, we use a non-empty filename

src/docker/remote.rs

@@ -1001,7 +1001,7 @@ symlink_recurse \"${{prefix}}\"
     {
         subcommand_or_exit(engine, "cp")?
             .arg("-a")
-            .arg(&format!("{container_id}:{mount_target_dir}",))
+            .arg(format!("{container_id}:{mount_target_dir}",))
             .arg(
                 package_dirs
                     .target()

src/docker/shared.rs

@@ -554,6 +554,7 @@ pub(crate) struct ChildContainerInfo {
 // that the drop only gets called once, even if we have
 // the signal handle invoked multiple times or it fails.
 #[allow(missing_debug_implementations)]
+#[derive(Default)]
 pub struct ChildContainer {
     info: Option<ChildContainerInfo>,
     exists: AtomicBool,